Re: [Openvpn-devel] [PATCH 0/3] Use the garbage collector when retrieving x509 fields

2012-04-01 Thread Alon Bar-Lev
I sent candidate. Please review. On Sat, Mar 31, 2012 at 1:51 AM, Alon Bar-Lev wrote: > Hm I missed that one. > > I don't like this patch... > > the gc_new() and gc_free() should be called once per function at > prolog and epilog. This is the whole point of gc, otherwise there is > no differe

Re: [Openvpn-devel] [PATCH 0/3] Use the garbage collector when retrieving x509 fields

2012-03-30 Thread Alon Bar-Lev
Hm I missed that one. I don't like this patch... the gc_new() and gc_free() should be called once per function at prolog and epilog. This is the whole point of gc, otherwise there is no difference between it and simple malloc. So: 1. in pkcs11.c it should be moved out of the loop. 2. In veri

Re: [Openvpn-devel] [PATCH 0/3] Use the garbage collector when retrieving x509 fields

2012-03-30 Thread David Sommerseth
On 14/02/12 11:11, Adriaan de Jong wrote: > A number of the x509 functions allocated memory directly, instead of > using the default OpenVPN convention: the garbage collector. This is > fixed in this series of patches. > > Adriaan These patches got ACKed by James and me at the developers meeting

[Openvpn-devel] [PATCH 0/3] Use the garbage collector when retrieving x509 fields

2012-02-14 Thread Adriaan de Jong
A number of the x509 functions allocated memory directly, instead of using the default OpenVPN convention: the garbage collector. This is fixed in this series of patches. Adriaan