Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-30 Thread Gert Doering
Hi, On Mon, Aug 29, 2016 at 11:03:00PM +0200, David Sommerseth wrote: > -std=c89 >Makes the LZ4 library we're shipping explode. We could fix that, but right now the LZ4 sources are "very close to upstream" (just a few file and #include renames) so that would make comparison "are these sane s

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-30 Thread Steffan Karger
On 30 August 2016 at 00:41, David Sommerseth wrote: > Just some more benchmarks. I just compiled successfully with -std=c99 > on an old Scientific Linux 6.5 (RHEL 6.5 clone) I found. Another > important detail, RHEL5 will reach the "End of Production" phase March > 2017, OpenVPN have generally s

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-30 Thread Jens Neuhalfen
Hi all, hopefully this message is not completely garbled by Apple Mail ... > > > […] > > Just some more benchmarks. I just compiled successfully with -std=c99 > on an old Scientific Linux 6.5 (RHEL 6.5 clone) I found. Another > important detail, RHEL5 will reach the "End of Production" phas

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 30/08/16 00:20, David Sommerseth wrote: > On 29/08/16 23:32, Steffan Karger wrote: >> HI, > >> On 29 August 2016 at 23:03, David Sommerseth >> wrote: >>> On 29/08/16 22:45, David Sommerseth wrote: On 28/08/16 21:42, Steffan Karger wrote: >>>

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 29/08/16 23:32, Steffan Karger wrote: > HI, > > On 29 August 2016 at 23:03, David Sommerseth > wrote: >> On 29/08/16 22:45, David Sommerseth wrote: >>> On 28/08/16 21:42, Steffan Karger wrote: Previously, we would use the compiler's default

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread Steffan Karger
HI, On 29 August 2016 at 23:03, David Sommerseth wrote: > On 29/08/16 22:45, David Sommerseth wrote: >> On 28/08/16 21:42, Steffan Karger wrote: >>> Previously, we would use the compiler's default C version, which >>> defaults to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for >>> clang, but mi

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread Steffan Karger
On 29 August 2016 at 21:29, Selva Nair wrote: > > On Sun, Aug 28, 2016 at 3:46 PM, Steffan Karger wrote: >> >> On 28 August 2016 at 21:42, Steffan Karger wrote: >> > Previously, we would use the compiler's default C version, which >> > defaults >> > to gnu89 for GCC < 5, gnu11 for GCC > 5, and c

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 29/08/16 22:45, David Sommerseth wrote: > On 28/08/16 21:42, Steffan Karger wrote: >> Previously, we would use the compiler's default C version, which >> defaults to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for >> clang, but might even differ

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/08/16 21:42, Steffan Karger wrote: > Previously, we would use the compiler's default C version, which > defaults to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for > clang, but might even differ per distro. > > One of the reasons to accept the

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-29 Thread Selva Nair
On Sun, Aug 28, 2016 at 3:46 PM, Steffan Karger wrote: > On 28 August 2016 at 21:42, Steffan Karger wrote: > > Previously, we would use the compiler's default C version, which defaults > > to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for clang, but might > even > > differ per distro. > > > >

Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-28 Thread Steffan Karger
On 28 August 2016 at 21:42, Steffan Karger wrote: > Previously, we would use the compiler's default C version, which defaults > to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for clang, but might even > differ per distro. > > One of the reasons to accept the gnu89 default of GCC < 4.9, was that

[Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

2016-08-28 Thread Steffan Karger
Previously, we would use the compiler's default C version, which defaults to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for clang, but might even differ per distro. One of the reasons to accept the gnu89 default of GCC < 4.9, was that MSVC didn't support c99. But in MSVC 2015, MS finanally fix