-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 23/04/10 12:56, Heikki Kallasjoki wrote:
> A minor nitpick, but...
>
> On Fri, Apr 23, 2010 at 11:35:05AM +0100, Davide Brini wrote:
>> On Friday 23 Apr 2010 11:13:21 David Sommerseth wrote:
>>> On 22/04/10 23:37, Davide Brini wrote:
--- openv
A minor nitpick, but...
On Fri, Apr 23, 2010 at 11:35:05AM +0100, Davide Brini wrote:
> On Friday 23 Apr 2010 11:13:21 David Sommerseth wrote:
> > On 22/04/10 23:37, Davide Brini wrote:
> > > --- openvpn-2.1.1/ssl.c 2010-02-28 22:17:45.0 +
> > > +++ openvpn-2.1.1-a/ssl.c 2010-04-22 2
On Friday 23 Apr 2010 11:13:21 David Sommerseth wrote:
> On 22/04/10 23:37, Davide Brini wrote:
> > --- openvpn-2.1.1/ssl.c 2010-02-28 22:17:45.0 +
> > +++ openvpn-2.1.1-a/ssl.c 2010-04-22 22:33:40.0 +0100
> > @@ -788,9 +788,28 @@ verify_callback (int preverify_ok, X509_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Davide!
Thanks a lot! This is looking pretty well, I have a few comments, though.
On 22/04/10 23:37, Davide Brini wrote:
>
> --- openvpn-2.1.1/ssl.c 2010-02-28 22:17:45.0 +
> +++ openvpn-2.1.1-a/ssl.c 2010-04-22 22:33:40.0
On Thursday 22 April 2010, Jan Just Keijser wrote:
> > The only doubt I have is about error handling; in this case, if the
> > allocation of the BIO fails, an error message is logged and nothing is
> > done. Is this the right thing to do?
>
> I don't know if a FATAL error is such a good thing - n
Davide Brini wrote:
On Thursday 22 April 2010, Davide Brini wrote:
(moving to -devel as this is obviously pertains there more than -users)
Sorry, too quick! I posted an incomplete version of the patch. The attached
one should be better.
The only doubt I have is about error handling;
On Thursday 22 April 2010, Davide Brini wrote:
> (moving to -devel as this is obviously pertains there more than -users)
Sorry, too quick! I posted an incomplete version of the patch. The attached
one should be better.
The only doubt I have is about error handling; in this case, if the allocatio
