Re: [Openvpn-devel] [PATCH] tun.c: refactor open_tun() implementation

2019-12-17 Thread Simon Rozman
Hi, > While patch looks big and scary, there are no functional changes at all, > just tossing code around. Indeed this looks scary. This patch chops Windows version of open_tun() into functions. Maybe, preserve functions in the original order to help diff pair the changes next time. Took me more

[Openvpn-devel] [PATCH] tun.c: refactor open_tun() implementation

2019-11-13 Thread Lev Stipakov
From: Lev Stipakov This makes Windows's tun_open() method easier to read by factoring out blocks of code, which perform certain task, into separate functions. This also minimizes inflation of if (!tt->wintun) { } blocks. While patch looks big and scary, there are no functional changes at al