Re: [Openvpn-devel] [PATCH] route: cleanup codestyle and make code more readable

2017-09-08 Thread Steffan Karger
Hi, On 06-09-17 22:45, David Sommerseth wrote: > On 23/08/17 07:30, Antonio Quartulli wrote: >> -static void delete_route(struct route_ipv4 *r, const struct tuntap *tt, >> unsigned int flags, const struct route_gateway_info *rgi, const struct >> env_set *es); >> +static void delete_route(struct

Re: [Openvpn-devel] [PATCH] route: cleanup codestyle and make code more readable

2017-09-07 Thread Antonio Quartulli
Hi, On 07/09/17 04:45, David Sommerseth wrote: > On 23/08/17 07:30, Antonio Quartulli wrote: >> This patch does not introduce any functional change. >> >> The code in route.c seems to have been written in different >> periods by different people, without sticking to a clear >> codestyle. For this

Re: [Openvpn-devel] [PATCH] route: cleanup codestyle and make code more readable

2017-09-06 Thread David Sommerseth
On 23/08/17 07:30, Antonio Quartulli wrote: > This patch does not introduce any functional change. > > The code in route.c seems to have been written in different > periods by different people, without sticking to a clear > codestyle. For this reason the code in this file in not > consistent at al

[Openvpn-devel] [PATCH] route: cleanup codestyle and make code more readable

2017-08-22 Thread Antonio Quartulli
This patch does not introduce any functional change. The code in route.c seems to have been written in different periods by different people, without sticking to a clear codestyle. For this reason the code in this file in not consistent at all. Clean it up by: - removing spaces from function invo