Hi,
>> Warning is printed inside tap_delete_adapter().
>
> tap_delete_adapter() is not called here.
Right, I managed to mistype tap_set_adapter_name().
> I was suggesting that if we do check the return value, let us also print a
> warning
> that renaming failed. That can't be done anywhere exce
Hi
On Wed, Sep 2, 2020 at 9:54 AM Lev Stipakov wrote:
> Hi,
>
> >> if (dwResult != ERROR_SUCCESS)
> >> {
> >> -tap_delete_adapter(NULL, &guidAdapter,
> &bRebootRequired);
> >> +/* failed renaming is not a fatal error, cont
Hi,
>> if (dwResult != ERROR_SUCCESS)
>> {
>> -tap_delete_adapter(NULL, &guidAdapter,
>> &bRebootRequired);
>> +/* failed renaming is not a fatal error, continue */
>> +dwResult = ERROR_SUCCESS;
>
>
> Th
Hi
On Wed, Sep 2, 2020 at 9:39 AM Lev Stipakov wrote:
> From: Lev Stipakov
>
> For some users renaming adapter mysteriously fails
> (https://github.com/OpenVPN/openvpn-build/issues/187),
>
> Since renaming is just a a "nice to have", make it not fatail.
>
> Signed-off-by: Lev Stipakov
> ---
>
From: Lev Stipakov
For some users renaming adapter mysteriously fails
(https://github.com/OpenVPN/openvpn-build/issues/187),
Since renaming is just a a "nice to have", make it not fatail.
Signed-off-by: Lev Stipakov
---
src/openvpnmsica/openvpnmsica.c | 3 ++-
1 file changed, 2 insertions(+),
