Hi,
On Thu, Nov 11, 2021 at 03:34:19PM +0100, Antonio Quartulli wrote:
> In any case, I'd suggest fixing git-send-email as copy/paste may
> introduce all kind of formatting bugs and may make the patch unusable.
Indeed. Line wraps, tab/space issues, "helpful mail clients", so
git-send-email is r
Hi,
On 11/11/2021 15:26, Pete Nelson wrote:
Should that have shown up as a separate entry in patchworks? I'm having
to cut/paste the results of git format-patch as I can't git send-email
from my dev box, and it looks like I may have missed editing the subject
line.
It shows up when it is de
Should that have shown up as a separate entry in patchworks? I'm having to
cut/paste the results of git format-patch as I can't git send-email from my
dev box, and it looks like I may have missed editing the subject line.
-- Pete
On Thu, Nov 11, 2021 at 1:34 PM Gert Doering wrote:
> Hi,
>
> On
When evaluating authentication plugins, stop further evaluation
once the first failure is detected.
implementation note: refactoring from a switch-case to an
if-else block allows the break statement to break out of the
outer for loop without additional control variables.
v2: add check for auth pl
Hi,
On Thu, Nov 11, 2021 at 01:23:43PM +, Pete Nelson wrote:
> Thank you, Frank. Amended patch so it applies only to auth attempts.
>
> Not sure how patchwork handles this.. my intent is this amended patch
> overwrites the patch from the OP.
> -- Pete
The best way to do that is to send the
Thank you, Frank. Amended patch so it applies only to auth attempts.
Not sure how patchwork handles this.. my intent is this amended patch
overwrites the patch from the OP.
-- Pete
---
src/openvpn/plugin.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
dif
> Pete Nelson hat am 09.11.2021 20:47 geschrieben:
>
>
> When evaluating authentication plugins, stop further evaluation
> once the first failure is detected.
>
Since plugin_call is only a thin wrapper around plugin_call_ssl I think this
would short-circuit ALL plugin calls. Doesn't sound lik
When evaluating authentication plugins, stop further evaluation
once the first failure is detected.
Implementation notes: Refactoring from a switch-case to an
if-else block allows the break statement to break out of the
outer for loop without additional control variables. Also,
moving the pr->n
