Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/12 15:32, Frederic Crozat wrote: > Le vendredi 06 janvier 2012 à 18:19 +0100, David Sommerseth a écrit : >> On 06/01/12 17:40, Frederic Crozat wrote: >>> Le vendredi 06 janvier 2012 à 17:22 +0100, David Sommerseth a >>> écrit : On 12/12/1

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-09 Thread Frederic Crozat
Le vendredi 06 janvier 2012 à 18:19 +0100, David Sommerseth a écrit : > On 06/01/12 17:40, Frederic Crozat wrote: > > Le vendredi 06 janvier 2012 à 17:22 +0100, David Sommerseth a écrit : > >> On 12/12/11 18:57, Frederic Crozat wrote: > >>> Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-08 Thread Samuli Seppänen
>>> In get_console_input_systemd() you do: >>> >>> + *input = 0; >>> >>> I think it would be better to do: CLEAR(*input) instead. Just setting >>> the first byte to 0, will not solve any leak possibilities. An >>> alternative is to use memset() directly, which the CLEAR() macro uses >>> (see ba

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-06 Thread David Sommerseth
On 06/01/12 17:40, Frederic Crozat wrote: > Le vendredi 06 janvier 2012 à 17:22 +0100, David Sommerseth a écrit : >> On 12/12/11 18:57, Frederic Crozat wrote: >>> Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a écrit : On 31/10/11 16:30, Frederic Crozat wrote: >> [...snip...] >> >>

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-06 Thread Frederic Crozat
Le vendredi 06 janvier 2012 à 17:22 +0100, David Sommerseth a écrit : > On 12/12/11 18:57, Frederic Crozat wrote: > > Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a écrit : > >> On 31/10/11 16:30, Frederic Crozat wrote: > [...snip...] > > Hey again, and thanks for this great rework! I

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/12/11 18:57, Frederic Crozat wrote: > Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a écrit : >> On 31/10/11 16:30, Frederic Crozat wrote: [...snip...] Hey again, and thanks for this great rework! I've looked through it, and it looks

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2011-12-12 Thread Frederic Crozat
Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a écrit : > On 31/10/11 16:30, Frederic Crozat wrote: > > Hi, > > > > as part of openSUSE switching to systemd by default, openVPN was made > > compatible with the systemd way of querying passphrase during boot > > (directly opening tty is

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2011-10-31 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/10/11 16:30, Frederic Crozat wrote: > Hi, > > as part of openSUSE switching to systemd by default, openVPN was made > compatible with the systemd way of querying passphrase during boot > (directly opening tty isn't supported). > Thanks a lot

[Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2011-10-31 Thread Frederic Crozat
Hi, as part of openSUSE switching to systemd by default, openVPN was made compatible with the systemd way of querying passphrase during boot (directly opening tty isn't supported). -- Frederic Crozat SUSE >From 02a9e6b213eba6dbb90b92b4d51e907718e46a56 Mon Sep 17 00:00:00 2001 From: Frederic Cr