Re: [Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

2020-12-21 Thread Lev Stipakov
Hi, > I've done some more investigation and I've found out that problem was > introduced in commit: > > 09ae6280 tun.c: revise the IPv4 ifconfig flow on Windows Right, we refactored code, added support for IPAPI and as a side-effect DHCP renew/release code is always executed no matter adapter typ

Re: [Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

2020-12-19 Thread Domagoj Pensa
Hi! I've done some more investigation and I've found out that problem was introduced in commit: 09ae6280 tun.c: revise the IPv4 ifconfig flow on Windows in the following change: @@ -6420,10 +6419,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun struct

Re: [Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

2020-12-18 Thread Lev Stipakov
Hi, The patch looks fine, but I wonder how did you manage to trigger this case? dhcp_release() or dhcp_renew() are called if dhcp_masq_post is set to true, which only happens for tap-windows6. fork_dhcp_action() is no-op unless dhcp-renew/dhcp-pre-release are explicitly defined in the ovpn profi

[Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

2020-12-15 Thread Domagoj Pensa
Wintun does not support DHCP. Running DHCP renew with Wintun adapter fails with a logged warning. Fixed so that DHCP renewing is called only for TAP-Windows6 adapters. --- src/openvpn/tun.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff