Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/12 20:16, Alon Bar-Lev wrote: > Looks good. If you testing this one, please ensure symbolic links > also works properly... :) Just to confirm, as I forgot to mention that in the 'applied' message earlier on. This was tested with symlinks on

Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/12 19:54, David Sommerseth wrote: > To avoid confusion between check_file_access() and > check_cmd_access() in the future, remove unneeded arguments from > check_cmd_access() > > As a command will always be a file, it should always check for

Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-02 Thread Gert Doering
Hi, On Wed, May 02, 2012 at 09:16:36PM +0300, Alon Bar-Lev wrote: > Looks good. > If you testing this one, please ensure symbolic links also works properly... > :) The man page for access() (on Linux) states: DESCRIPTION access() checks whether the calling process can access the file p

Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-02 Thread Alon Bar-Lev
Looks good. If you testing this one, please ensure symbolic links also works properly... :) On Wed, May 2, 2012 at 8:54 PM, David Sommerseth wrote: > To avoid confusion between check_file_access() and check_cmd_access() in the > future, remove unneeded arguments from check_cmd_access() > > As a c

[Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-02 Thread David Sommerseth
To avoid confusion between check_file_access() and check_cmd_access() in the future, remove unneeded arguments from check_cmd_access() As a command will always be a file, it should always check for CHKACC_FILE and nothing else. And as the commands always will need X_OK, check only for that. One