Re: [Openvpn-devel] [PATCH] Set DNS Domain using iservice

2020-09-25 Thread Selva Nair
Hi Thanks for the review. On Fri, Sep 25, 2020 at 5:24 AM Lev Stipakov wrote: > Hi, > > > Note: this will set the domain twice if both v4 and v6 DNS > > servers are defined. It cant hurt, but could be avoided by > > making the domain setting a separate call from the DNS > > server setting. > >

Re: [Openvpn-devel] [PATCH] Set DNS Domain using iservice

2020-09-25 Thread Lev Stipakov
Hi, > Note: this will set the domain twice if both v4 and v6 DNS > servers are defined. It cant hurt, but could be avoided by > making the domain setting a separate call from the DNS > server setting. I think we should do that - there is no reason to make expensive call twice: $ time wmic niccon

[Openvpn-devel] [PATCH] Set DNS Domain using iservice

2020-09-24 Thread selva . nair
From: Selva Nair Use wmic instead of directly editing the registry as the former does not take full effect unless the dns client service is restarted. Editing the registry appears to work erratically depending on whether its followed with a dchp renew or ipconfig /registerdns etc. DOMAIN-SEARCH