Re: [Openvpn-devel] [PATCH] Replace variable length array with malloc

2015-10-20 Thread Lev Stipakov
Why OPENSSL_malloc() in particular? I looked for other malloc calls in that file and only example I've found was OPENSSL_malloc in show_available_curves(). On the other side Dr. Stephen Henson says (quote unedited): http://permalink.gmane.org/gmane.comp.encryption.openssl.user/11291 You do

Re: [Openvpn-devel] [PATCH] Replace variable length array with malloc

2015-10-20 Thread Lev Stipakov
> Why OPENSSL_malloc() in particular? I looked for other malloc calls in that file and only example I've found was OPENSSL_malloc in show_available_curves(). On the other side Dr. Stephen Henson says (quote unedited): http://permalink.gmane.org/gmane.comp.encryption.openssl.user/11291 > You

Re: [Openvpn-devel] [PATCH] Replace variable length array with malloc

2015-10-20 Thread Gert Doering
Hi, On Tue, Oct 20, 2015 at 04:22:59PM +0300, Lev Stipakov wrote: > Commit > https://github.com/OpenVPN/openvpn/commit/685e486e8b8f70c25f09590c24762ff734f94a51 > introduced a variable length array. Although C99 supports that, MSVS 2013 > still requires > size of array to be compiler time constan

[Openvpn-devel] [PATCH] Replace variable length array with malloc

2015-10-20 Thread Lev Stipakov
Commit https://github.com/OpenVPN/openvpn/commit/685e486e8b8f70c25f09590c24762ff734f94a51 introduced a variable length array. Although C99 supports that, MSVS 2013 still requires size of array to be compiler time constant. As a fix, use OPENSSL_malloc/free. Signed-off-by: Lev Stipakov --- src/