-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 18/11/10 17:07, Samuli Seppänen wrote:
|
|> Samuli Seppänen wrote:
|>
|>> here's the next version of the patch;
|>>
|>
|> Functionally fine!
|>
|>
|>
|>> def main(config):
|>> +
|>> +# Do a signed build by default
|>> +unsignedBuild=False
Samuli Seppänen wrote:
> From 804aa21a12f74de4142305ed415b33a43e5fc276 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=
> Date: Thu, 18 Nov 2010 18:00:54 +0200
> Subject: [PATCH] Added command-line option parser and an unsigned build
> option to build_all.py
>
> Modified win/b
> Samuli Seppänen wrote:
>
>> here's the next version of the patch;
>>
>
> Functionally fine!
>
>
>
>> def main(config):
>> +
>> +# Do a signed build by default
>> +unsignedBuild=False
>>
>
> Maybe name the option signedBuild instead? :)
>
>
>
>> +# Check if the Sig
Hi Peter,
Fair points. Me fix and resend.
--
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc
irc freenode net: mattock
> Samuli Seppänen wrote:
>
>> here's the next version of the patch;
>>
>
> Functionally fine!
>
>
>
>> def main(config):
>> +
>> +# Do a signed b
Samuli Seppänen wrote:
> here's the next version of the patch;
Functionally fine!
> def main(config):
> +
> +# Do a signed build by default
> +unsignedBuild=False
Maybe name the option signedBuild instead? :)
> +# Check if the SignTool module is present. This avoids ImportErrors
>> I agree that there should be no way one could make an unsigned build by
>> mistake. I think dazo's suggestion about having a command-line switch
>> ("force unsigned build") is a good one. The SIGNTOOL variable could then
>> be used to just locate signtool.exe and nothing else. This would make i
Hello,
This again, raises the modulation of openvpn project.
*NOBODY* wants/needs to modify the driver, most people lacks the
skills and interest. Usually people wants to patch openvpn userspace
components.
The driver should come in its own .msi signed (msi + driver).
OpenVPN installation should
Hi,
On Fri, Nov 12, 2010 at 05:50:19PM +0100, David Sommerseth wrote:
> If I've understood it correctly, this is related to signing the Windows
> TUN/TAP driver. So if you don't have a signing key/tool available, it
> is still possible to build the rest of OpenVPN. You might even manage
> to ins
Samuli Seppänen wrote:
> Peter: settings.in is stored in git.
Ok.
> I agree that there should be no way one could make an unsigned build by
> mistake. I think dazo's suggestion about having a command-line switch
> ("force unsigned build") is a good one. The SIGNTOOL variable could then
> be used
> > What if build_all.py did this:
>
> > - Check if SIGNTOOL is enabled in settings.in:
> > - Yes: fail if can't import "sign" module
> > - No: don't fail if can't import "sign" module
>
> > I think existence of the SIGNTOOL variable gives a good clue of user's
> > intentions. Note that the bu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/11/10 18:11, Samuli Seppänen wrote:
>
>> On 12/11/10 17:55, Peter Stuge wrote:
>>> David Sommerseth wrote:
>> Modified win/build_all.py so that build does not fail even if
>> the optional signtool python class is not available.
> Wha
Samuli Seppänen wrote:
> What if build_all.py did this:
>
> - Check if SIGNTOOL is enabled in settings.in:
> - Yes: fail if can't import "sign" module
> - No: don't fail if can't import "sign" module
This also sounds good. (Who typically creates settings.in? Is one in git?)
//Peter
David Sommerseth wrote:
> >> So if you don't have a signing key/tool available, it is still
> >> possible to build the rest of OpenVPN.
> >
> > Fine, but this is not really acceptable when James&co builds OpenVPN,
> > so I am requesting a solution that allows them to specify to the
> > build proce
> On 12/11/10 17:55, Peter Stuge wrote:
> > David Sommerseth wrote:
> Modified win/build_all.py so that build does not fail even if
> the optional signtool python class is not available.
> >>> What is it needed for? Is it really *always* optional?
> >> If I've understood it correctly, th
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/11/10 17:55, Peter Stuge wrote:
> David Sommerseth wrote:
Modified win/build_all.py so that build does not fail even if
the optional signtool python class is not available.
>>>
>>> What is it needed for? Is it really *always* optional?
David Sommerseth wrote:
> >> Modified win/build_all.py so that build does not fail even if
> >> the optional signtool python class is not available.
> >
> > What is it needed for? Is it really *always* optional?
>
> If I've understood it correctly, this is related to signing the Windows
> TUN/TAP
> Samuli Seppänen wrote:
>
>> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001
>> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=
>> Date: Fri, 12 Nov 2010 17:32:19 +0200
>> Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py
>>
>> Modified win/build_all
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/11/10 17:36, Peter Stuge wrote:
> Samuli Seppänen wrote:
>> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001
>> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=
>> Date: Fri, 12 Nov 2010 17:32:19 +0200
>> Subject: [PATCH] Removed h
Samuli Seppänen wrote:
> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=
> Date: Fri, 12 Nov 2010 17:32:19 +0200
> Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py
>
> Modified win/build_all.py so that b
From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=
Date: Fri, 12 Nov 2010 17:32:19 +0200
Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py
Modified win/build_all.py so that build does not fail even if the opt
20 matches
Mail list logo
