Re: [Openvpn-devel] [PATCH] Remove quadratic complexity from openvpn_base64_decode()

2014-09-06 Thread Gert Doering
Hi, On Thu, Sep 04, 2014 at 01:13:17PM +0200, Steffan Karger wrote: > Attached a patch for a change suggested by Jann Horn, to remove the > quadratic complexity from openvpn_base64_decode(). [..] > That said, I do like the suggestion to make the code constant time. I'd > say it should be applied t

[Openvpn-devel] [PATCH] Remove quadratic complexity from openvpn_base64_decode()

2014-09-04 Thread Steffan Karger
Hi, Attached a patch for a change suggested by Jann Horn, to remove the quadratic complexity from openvpn_base64_decode(). The suggestion was originally sent to the security list, because quadratic complexity can potentially lead to a denial-of-service attack vector. In the current OpenVPN codeba