Hi,
On 30/03/2020 07:55, Gert Doering wrote:
>> Not sure now what would be the best approach forward. Picking the commit
>> contents from a rebased icsopenvpn branch would be one way (I can provide
>> commitish references I reviewed, if needed). Another approach is for Arne to
>> resend rebased p
Hi,
On Sun, Mar 29, 2020 at 11:54:36PM +0200, David Sommerseth wrote:
> > Applying: Reformat all source files
> > error: patch failed: src/openvpn/tun.c:3418
> > error: src/openvpn/tun.c: patch does not apply
> > Patch failed at 0001 Reformat all source files
>
> Ahh, sorry ... I did the reviews
On 28/03/2020 12:33, Gert Doering wrote:
> Hi,
>
> On Fri, Mar 27, 2020 at 04:24:00PM +0100, David Sommerseth wrote:
>> On 16/11/2019 11:28, Arne Schwabe wrote:
>>> Over time some patches slipped in that were not 100% complient to uncrustify
>>> This rerun fixes those issues
> [..]
>> Only done qu
Hi,
On Fri, Mar 27, 2020 at 04:24:00PM +0100, David Sommerseth wrote:
> On 16/11/2019 11:28, Arne Schwabe wrote:
> > Over time some patches slipped in that were not 100% complient to uncrustify
> > This rerun fixes those issues
[..]
> Only done quick code review and RHEL-7 build. Changes looks re
On 16/11/2019 11:28, Arne Schwabe wrote:
> Over time some patches slipped in that were not 100% complient to uncrustify
> This rerun fixes those issues
>
> This run used Uncrustify-0.69.0_f
> ---
> src/openvpn/buffer.c | 2 +-
> src/openvpn/crypto.h | 2 +-
> src/openv
Over time some patches slipped in that were not 100% complient to uncrustify
This rerun fixes those issues
This run used Uncrustify-0.69.0_f
---
src/openvpn/buffer.c | 2 +-
src/openvpn/crypto.h | 2 +-
src/openvpn/networking.h | 4 +--
src/openvpn/networking