Hi,
On Thu, Apr 26, 2012 at 09:20:14PM +0300, Alon Bar-Lev wrote:
> > We want to *reduce* the number of #ifdef in the code.
>
> Not necessary, I would like to make it compatible with other well
> behaved projects out there.
You are young, and will learn.
"Well behaved projects" are not those th
On Thu, Apr 26, 2012 at 9:17 PM, Gert Doering wrote:
> Hi,
>
> On Thu, Apr 26, 2012 at 09:06:19PM +0300, Alon Bar-Lev wrote:
>> Right, the ipv6 was added indeed differently, without this conditionals.
>
> You missed the part that JJO's IPv6 code *was* added with conditionals,
> and that caused pro
Hi,
On Thu, Apr 26, 2012 at 09:06:19PM +0300, Alon Bar-Lev wrote:
> Right, the ipv6 was added indeed differently, without this conditionals.
You missed the part that JJO's IPv6 code *was* added with conditionals,
and that caused problems. We *removed* the conditionals, and the resulting
code is
On Thu, Apr 26, 2012 at 9:01 PM, Gert Doering wrote:
> Hi,
>
> On Thu, Apr 26, 2012 at 08:35:54PM +0300, Alon Bar-Lev wrote:
>> At embedded system and several distros like Gentoo, the ipv6 should be
>> made enable/disabled, just like any other project.
>> It is the same #ifdef as we already have t
Hi Alon,
2012/4/26 Alon Bar-Lev :
> At embedded system and several distros like Gentoo, the ipv6 should be
> made enable/disabled, just like any other project.
> It is the same #ifdef as we already have these in code.
> Even in 2012 kernels can be compiled without ipv6.
If embedded systems really
Hi,
On Thu, Apr 26, 2012 at 08:35:54PM +0300, Alon Bar-Lev wrote:
> At embedded system and several distros like Gentoo, the ipv6 should be
> made enable/disabled, just like any other project.
> It is the same #ifdef as we already have these in code.
> Even in 2012 kernels can be compiled without i
On Thu, Apr 26, 2012 at 8:56 PM, Fabian Knittel
wrote:
> Hi Alon,
>
> 2012/4/26 Alon Bar-Lev :
>> At embedded system and several distros like Gentoo, the ipv6 should be
>> made enable/disabled, just like any other project.
>> It is the same #ifdef as we already have these in code.
>> Even in 2012
On Thu, Apr 26, 2012 at 8:35 PM, Alon Bar-Lev wrote:
> On Thu, Apr 26, 2012 at 8:32 PM, David Sommerseth
> wrote:
>> On 26/04/12 19:24, Gert Doering wrote:
>>> Hi,
>>>
>>> On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote:
I plan to add --enable-ipv6/--disable-ipv6 to explicit sup
On Thu, Apr 26, 2012 at 8:32 PM, David Sommerseth
wrote:
> On 26/04/12 19:24, Gert Doering wrote:
>> Hi,
>>
>> On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote:
>>> I plan to add --enable-ipv6/--disable-ipv6 to explicit support
>>> ipv6.
>>
>> NAK.
>>
>> We considered this, and this wi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 26/04/12 19:24, Gert Doering wrote:
> Hi,
>
> On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote:
>> I plan to add --enable-ipv6/--disable-ipv6 to explicit support
>> ipv6.
>
> NAK.
>
> We considered this, and this will add a shitload
Hi,
On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote:
> I plan to add --enable-ipv6/--disable-ipv6 to explicit support ipv6.
NAK.
We considered this, and this will add a shitload of #ifdefs which will
make maintenance of the code a lot harder.
(We actually *removed* all the #ifdefs
I plan to add --enable-ipv6/--disable-ipv6 to explicit support ipv6.
This is part of syshead fixups.
Cleaning a lot of code of autoconf auto detection of socket functions.
On Thu, Apr 26, 2012 at 2:51 PM, David Sommerseth wrote:
> These days it is highly unlikely that OpenVPN will be built in a n
Hi,
On Thu, Apr 26, 2012 at 03:11:54PM +0200, Fabian Knittel wrote:
> Gert appears to be happy, so I'm happy, but I don't quite understand
> what you're saying here. What part broke? HAVE_TUN_PI and HAVE_IPHDR
> aren't always detected although they should be? Or the failed
> detection affects non-
Hi David,
2012/4/26 David Sommerseth :
> These days it is highly unlikely that OpenVPN will be built in a non-IPv6
> capable Linux environment.
Agreed.
> This also solves an issue which was introduced in commit 51bd56f46f55177cf0f8b
> where HAVE_TUN_PI and HAVE_IPHDR is no longer detected. As t
Hi,
On Thu, Apr 26, 2012 at 01:51:25PM +0200, David Sommerseth wrote:
> These days it is highly unlikely that OpenVPN will be built in a non-IPv6
> capable Linux environment. So remove compile-time related macros identifying
> that.
>
> This also solves an issue which was introduced in commit 51
These days it is highly unlikely that OpenVPN will be built in a non-IPv6
capable Linux environment. So remove compile-time related macros identifying
that.
This also solves an issue which was introduced in commit 51bd56f46f55177cf0f8b
where HAVE_TUN_PI and HAVE_IPHDR is no longer detected. As t
16 matches
Mail list logo
