Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread David Sommerseth
On 25/05/16 17:27, Selva Nair wrote: > > Well, if a major rewrite of console input is planned, consider > replacing getpass() as well. It has arbitrary password length > limitations on some platforms. At the same time I'm not sure I > understand the need for this overhaul. Currently the interface

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
On Tue, May 24, 2016 at 6:53 PM, Selva Nair wrote: > Do not mask input when echo is requested. Useful for username > input and sometimes for challenge response. > > Signed-off-by: Selva Nair Patch withdrawn in deference to David's pending patches that address this among other things.. Also thi

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
Hi David, On Wed, May 25, 2016 at 12:17 PM, David Sommerseth wrote: > On 25/05/16 17:27, Selva Nair wrote: > > > > Well, if a major rewrite of console input is planned, consider > > replacing getpass() as well. It has arbitrary password length > > limitations on some platforms. At the same time

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread Selva Nair
On Wed, May 25, 2016 at 6:12 AM, David Sommerseth wrote: > On 25/05/16 00:53, Selva Nair wrote: > > Do not mask input when echo is requested. Useful for username > > input and sometimes for challenge response. > > > > Signed-off-by: Selva Nair > > .. > > Hi Selva, > > Thanks a lot! This patch d

Re: [Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-25 Thread David Sommerseth
On 25/05/16 00:53, Selva Nair wrote: > Do not mask input when echo is requested. Useful for username > input and sometimes for challenge response. > > Signed-off-by: Selva Nair > --- > src/openvpn/console.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/open

[Openvpn-devel] [PATCH] Pass echo option to systemd-ask-password

2016-05-24 Thread Selva Nair
Do not mask input when echo is requested. Useful for username input and sometimes for challenge response. Signed-off-by: Selva Nair --- src/openvpn/console.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/openvpn/console.c b/src/openvpn/console.c index 86331a1..8a