Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 11:49, David Sommerseth wrote: > From: David Sommerseth > > This is to include peercred support on hosts where _GNU_SOURCE is not > defined by default. This issue has been found on Gentoo with glibc-2.8. > > The solution was discussed o

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/13/2010 05:34:19 PM, Matthias Andree wrote: > Karl O. Pinc wrote on 2010-03-10: > > But, you _don't_ have to run ./configure every time. You > > You do. Yes. Thanks. I don't know what I was thinking. Karl Free Software: "You don't pay back, you pay forward." -- Ro

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Alon Bar-Lev wrote on 2010-03-10: If you patch autoconf/automake stuff, you *MUST* add autoconf/automake dependency to your package, so you can regenerate the files. It is much simpler to patch also the generated files and avoid this dependency. But it is packager's call. For distributions and

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Karl O. Pinc wrote on 2010-03-10: On 03/10/2010 11:41:49 AM, Alon Bar-Lev wrote: On Wed, Mar 10, 2010 at 7:39 PM, Karl O. Pinc wrote: > In other words ./configure is not expected to be run under normal > circumstances. > > The whole point of autoconf is to produce something that can > be made

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 12:09:58 PM, David Sommerseth wrote: > > But how is it then that Alon does not run ./configure > > on machine 2 above? > > The fact is that I believe he does run ./configure on all machines. > Autotools just generates a set up files which is not depending on > anything else than bas

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

David Sommerseth wrote: > > Nothing should patch the autotools generated files, just the > > autotools source files. Right? > > Correct, that was my mistake. I initially meant autotools source > files. As Alon pointed out it would be less intrusive to patch the files that were generated by auto

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Karl O. Pinc wrote: > And, to reiterate, applying patches within an rpm > spec file is normal, expected, and part of the > rpm design so a certain level of "development" is supported. Should also not be a problem, since those patches are likely to start from a known release tarball, so autoconf st

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 19:04, Karl O. Pinc wrote: > On 03/10/2010 11:54:52 AM, David Sommerseth wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/03/10 18:39, Karl O. Pinc wrote: >>> On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: I will

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On Wed, Mar 10, 2010 at 8:04 PM, Karl O. Pinc wrote: > But how is it then that Alon does not run ./configure > on machine 2 above? You do... On the target machine: tar -xf @TARBALL@ cd @TOP@ ./configure make install You must run configure in order to generate Makefile in autoconf environment.

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:54:52 AM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/03/10 18:39, Karl O. Pinc wrote: > > On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: > >> I will try to explain again. > >> > >> You have two roles of environments: > >> > >> 1. Developer/

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:41:49 AM, Alon Bar-Lev wrote: > On Wed, Mar 10, 2010 at 7:39 PM, Karl O. Pinc wrote: > > In other words ./configure is not expected to be run under normal > > circumstances. > > > > The whole point of autoconf is to produce something that can > > be made into a tarball that only r

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:39, Karl O. Pinc wrote: > On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: >> I will try to explain again. >> >> You have two roles of environments: >> >> 1. Developer/packager workstation. >> >> 2. Target environment. >> >> For example, 1

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:37:57 AM, David Sommerseth wrote: > On 10/03/10 18:26, Peter Stuge wrote: > > The only way autoconf on that RHEL4.6 would be relevant is if those > > RHEL4.6 systems strictly need to build directly from git source, as > > opposed to building from a prepared tarball. Is that the ca

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On Wed, Mar 10, 2010 at 7:39 PM, Karl O. Pinc wrote: > In other words ./configure is not expected to be run under normal > circumstances. > > The whole point of autoconf is to produce something that can > be made into a tarball that only requires "make; make install" > to compile and install. You

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: > I will try to explain again. > > You have two roles of environments: > > 1. Developer/packager workstation. > > 2. Target environment. > > For example, 1 would be my computer, and 2 would be the old redhat > computer. > > You go to (1) and do: >

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:26, Peter Stuge wrote: > David Sommerseth wrote: >> it's a requirement to be able to build OpenVPN on RHEL4.6. > > As Alon explained, building is not the problem. autotools are used > when preparing git source for build. This is done fo

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:19, Alon Bar-Lev wrote: > I will try to explain again. > > You have two roles of environments: > > 1. Developer/packager workstation. > > 2. Target environment. > > For example, 1 would be my computer, and 2 would be the old redhat c

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Peter Stuge wrote: > RHEL4.6 can easily build a release that was prepared using the most > recent autoconf. In fact, I would suggest that using the newest autotools when creating the package makes it *more* likely to build effortlessly on older systems. //Peter

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

David Sommerseth wrote: > it's a requirement to be able to build OpenVPN on RHEL4.6. As Alon explained, building is not the problem. autotools are used when preparing git source for build. This is done for every release, so that there is a ready-made configure script included in the tarball. When

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

I will try to explain again. You have two roles of environments: 1. Developer/packager workstation. 2. Target environment. For example, 1 would be my computer, and 2 would be the old redhat computer. You go to (1) and do: $ autoreconf -ivf $ ./configure && make dist Now, you transfer the tarb

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:03, Alon Bar-Lev wrote: > On Wed, Mar 10, 2010 at 6:50 PM, David Sommerseth > wrote: >> I'm willing to accept patches with updates as long as it don't break the >> oldest version OpenVPN need to support (autotools/autoconf v2.59). If >

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On Wed, Mar 10, 2010 at 6:50 PM, David Sommerseth wrote: > I'm willing to accept patches with updates as long as it don't break the > oldest version OpenVPN need to support (autotools/autoconf v2.59).  If > it can be built an old RHEL4.6 installation, it's good enough for James, > according to the

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 17:42, Alon Bar-Lev wrote: > This is not the way to do it. > > Use AC_USE_SYSTEM_EXTENSIONS in autoconf, which detects libc settings. > > The current autoconf shape is poor, long ago I offered James to > rewrite it but he refused. I only

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

This is not the way to do it. Use AC_USE_SYSTEM_EXTENSIONS in autoconf, which detects libc settings. The current autoconf shape is poor, long ago I offered James to rewrite it but he refused. I only made it partially work for cross compile. There are a lot of none standard/best practice stuff th

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 11:49, David Sommerseth wrote: > From: David Sommerseth > > This is to include peercred support on hosts where _GNU_SOURCE is not > defined by default. This issue has been found on Gentoo with glibc-2.8. > > The solution was discussed o

[Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

From: David Sommerseth This is to include peercred support on hosts where _GNU_SOURCE is not defined by default. This issue has been found on Gentoo with glibc-2.8. The solution was discussed on the IRC meeting March 4, 2010 in #openvpn-discussions.