Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/05/10 04:40, Brian Raderman wrote: > Hi David, > > On May 1, 2010, at 9:41 AM, David Sommerseth wrote: >> Looking good! You also have dmsg() I believe for debugging as well. >> But then I believe the logging will only be enabled if configured w

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-05 Thread Brian Raderman
Hi David, On May 1, 2010, at 9:41 AM, David Sommerseth wrote: Looking good! You also have dmsg() I believe for debugging as well. But then I believe the logging will only be enabled if configured with - --enable-debug, iirc. Anyway, that was just a side note. If you want it like it is now,

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/05/10 08:18, Brian Raderman wrote: > Hi David, > > Thank you for taking a look at the patch and providing such thorough feedback > so > quickly. You're welcome! I'm happy to see you updating the patch and bringing it one step closer for incl

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread Toby Thain
On 1-May-10, at 4:18 PM, Brian Raderman wrote: Hi David, ... * Removed the dummy1() function from keychain.c. Keychain.c/.h are based on cryptoapi.c/.h in the openvpn source tree. When editing the original file to work with the Keychain services libraries instead of the Windows Crypto A

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread Brian Raderman
Hi David, Thank you for taking a look at the patch and providing such thorough feedback so quickly. I have done everything that you asked: * Changed printf() calls to use msg(). The prints are not actually used right now, but they are a part of the debug code that I wrote for testing the cer

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-04-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/04/10 07:17, Brian Raderman wrote: > Hello, > > This patch adds support for using certificates stored in the Mac OSX Keychain > to authenticate with the OpenVPN server. This works with certificates stored > on the computer as well as certificat

[Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-04-28 Thread Brian Raderman
Hello, This patch adds support for using certificates stored in the Mac OSX Keychain to authenticate with the OpenVPN server. This works with certificates stored on the computer as well as certificates on hardware tokens that support Apple's tokend interface. It has been tested with an Aladdi