Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-05-02 Thread Steffan Karger
Hi, Hi, On 02-05-18 20:40, Selva Nair wrote: > On Wed, May 2, 2018 at 2:30 PM, Steffan Karger wrote: >> On 26-03-18 18:36, Ning Wei via Openvpn-devel wrote: >>> Both of key_method_2_write and key_method_2_read take >>> TLS_Channel_Bug_Size as buffer size. The current size, 2048 is not >>> enough

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-05-02 Thread Selva Nair
Hi, On Wed, May 2, 2018 at 2:30 PM, Steffan Karger wrote: > Hi, > > On 26-03-18 18:36, Ning Wei via Openvpn-devel wrote: >> Both of key_method_2_write and key_method_2_read take >> TLS_Channel_Bug_Size as buffer size. The current size, 2048 is not >> enough to read/write a long password response

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-05-02 Thread Steffan Karger
Hi, On 26-03-18 18:36, Ning Wei via Openvpn-devel wrote: > Both of key_method_2_write and key_method_2_read take > TLS_Channel_Bug_Size as buffer size.  The current size, 2048 is not > enough to read/write a long password response.  I have notice the > management interface has a much smaller than

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-26 Thread Ning Wei via Openvpn-devel
Both of key_method_2_write and key_method_2_read take TLS_Channel_Bug_Size as buffer size.  The current size, 2048 is not enough to read/write a long password response.  I have notice the management interface has a much smaller than 2048 buffer size to read/write.  Currently, if the management

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-19 Thread Selva Nair
Hi, On Mon, Mar 19, 2018 at 5:00 PM, Ning Wei wrote: > Sorry, I did not state the intent clearly in the request. > > We wanted to use password field to pass authentication string, such as Token > string, > which can be long, the user auth plug in on the sever side can validate the > token as > th

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-19 Thread Ning Wei via Openvpn-devel
Sorry, I did not state the intent clearly in the request. We wanted to use password field to pass authentication string, such as Token string,which can be long, the user auth plug in on the sever side can validate the token asthe part authentication step. Acquiring a token, such as JWT, usually

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-16 Thread Selva Nair
Hi, Apologies in advance if I'm misreading the intent of this patch. On Fri, Mar 16, 2018 at 12:40 PM, Ning Wei via Openvpn-devel wrote: > Increase TLS_CHANNEL_BUF_SIZE to 4096. When the build is enabled with > ENABLE_PKCS11, the password field can be 4096. The old size of > TLS_CHANNEL_BUF_SIZ

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-16 Thread Ning Wei via Openvpn-devel
Thank you for reminding this.  The reason that I have resent was there was a typo in the commit comment. Best regards,Ning On Friday, March 16, 2018, 9:46:07 AM PDT, Gert Doering wrote: Hi, On Fri, Mar 16, 2018 at 09:40:59AM -0700, Ning Wei via Openvpn-devel wrote: > Increase TLS_CHAN

Re: [Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-16 Thread Gert Doering
Hi, On Fri, Mar 16, 2018 at 09:40:59AM -0700, Ning Wei via Openvpn-devel wrote: > Increase TLS_CHANNEL_BUF_SIZE to 4096. When the build is enabled with > ENABLE_PKCS11, the password field can be 4096. The old size of > TLS_CHANNEL_BUF_SIZE was 2048, which is not enough. Please do not keep re-sen

[Openvpn-devel] [PATCH] Increase TLS Control Channel Buffer Size

2018-03-16 Thread Ning Wei via Openvpn-devel
Increase TLS_CHANNEL_BUF_SIZE to 4096. When the build is enabled with ENABLE_PKCS11, the password field can be 4096. The old size of TLS_CHANNEL_BUF_SIZE was 2048, which is not enough. Signed-off-by: Ning Wei --- src/openvpn/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -