On Tue, Dec 15, 2015 at 12:51 PM, Selva Nair wrote:
> This could be a small ~2 line patch -- easier to review and test.
>
I'll post a 3-part patch as a reply to this email. They are: (1) the "if"
removal that fixes the bug, (2) the prompt buffer moves, and (3) the
reindentation. If you end up w
Hi,
On Mon, Dec 14, 2015 at 4:10 PM, Selva Nair wrote:
>
>> I took a quick look and it seems a simplified patch that addresses the
>> most critical-sounding issue (challenge/reponse not prompted for
>> from stdin) may be more useful.
>>
>
>
> That's exactly what that patch is.
>
Ok, now looking
On Mon, Dec 14, 2015 at 4:10 PM, Selva Nair wrote:
> I took a quick look and it seems a simplified patch that addresses the
> most critical-sounding issue (challenge/reponse not prompted for
> from stdin) may be more useful.
>
That's exactly what that patch is.
>From the cover-letter to the pat
Hi,
On Mon, Dec 14, 2015 at 4:56 PM, Wayne Davison wrote:
>
> On Thu, Dec 10, 2015 at 8:57 AM, Wayne Davison
> wrote:
>
>> src/openvpn/misc.c | 119
>> +
>> 1 file changed, 57 insertions(+), 62 deletions(-)
>>
>
> Any questions I can answer a
On Thu, Dec 10, 2015 at 8:57 AM, Wayne Davison wrote:
> src/openvpn/misc.c | 119
> +
> 1 file changed, 57 insertions(+), 62 deletions(-)
>
Any questions I can answer about this patch? This is such a
straight-forward bug with a simple fix tha
---
src/openvpn/misc.c | 119 +
1 file changed, 57 insertions(+), 62 deletions(-)
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c
index bc411bf..83e10f7 100644
--- a/src/openvpn/misc.c
+++ b/src/openvpn/misc.c
@@ -1132,74 +1132,69 @@ get_us
