Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Lev Stipakov
And of course I forgot non-dco dummy implementation (which we don't call yet, because on Windows dco is always defined) https://github.com/lstipakov/openvpn/commit/f223bef8449f15ff5de06acdfee16088b855c47a ke 27. huhtik. 2022 klo 16.18 Lev Stipakov (lstipa...@gmail.com) kirjoitti: > How about we'

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Lev Stipakov
How about we'll add dco_check_timeout(int, context) to dco.h with platform specific implementations? Here is what I just did for Windows (Linux part is no-nop): https://github.com/lstipakov/openvpn/commit/ce242896c621273578a446c5194d5ca6aee04237 ke 27. huhtik. 2022 klo 15.32 Lev Stipakov (lstipa.

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Lev Stipakov
Hi, @Lev, just a heads up: does dco-win deal with this case? It would be > good to have a look on your side too. > Good point - this functionality (dco keepalive timeout) works in openvpn3 but not in openvpn2. dco-win notifies userspace about keepalive timeout by returning certain error code (ST

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Kristof Provost via Openvpn-devel
On 27 Apr 2022, at 9:55, Antonio Quartulli wrote: > Hi Kristof, > > On 27/04/2022 09:48, Kristof Provost via Openvpn-devel wrote: >> From: Kristof Provost >> >> Handle the DCO driver telling us that the peer went away, even if we're >> not running in multi-instance mode. > > thanks for catching an

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Antonio Quartulli
Hi, On 27/04/2022 09:59, Gert Doering wrote: Hi, On Wed, Apr 27, 2022 at 09:55:24AM +0200, Antonio Quartulli wrote: --- a/src/openvpn/forward.c +++ b/src/openvpn/forward.c @@ -,6 +,12 @@ process_incoming_dco(struct context *c) dco_do_read(dco); +if (dco->dco_message_

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Gert Doering
Hi, On Wed, Apr 27, 2022 at 09:55:24AM +0200, Antonio Quartulli wrote: > > --- a/src/openvpn/forward.c > > +++ b/src/openvpn/forward.c > > @@ -,6 +,12 @@ process_incoming_dco(struct context *c) > > > > dco_do_read(dco); > > > > +if (dco->dco_message_type == OVPN_NOTIF_DEL_P

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Antonio Quartulli
Hi Kristof, On 27/04/2022 09:48, Kristof Provost via Openvpn-devel wrote: From: Kristof Provost Handle the DCO driver telling us that the peer went away, even if we're not running in multi-instance mode. thanks for catching and fixing this. It was indeed on the todo list, but well hidden un

[Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-27 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Handle the DCO driver telling us that the peer went away, even if we're not running in multi-instance mode. Signed-off-by: Kristof Provost --- src/openvpn/forward.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c in

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-26 Thread Arne Schwabe
Am 26.04.22 um 18:56 schrieb Arne Schwabe: Am 26.04.22 um 18:29 schrieb Kristof Provost via Openvpn-devel: From: Kristof Provost Handle the DCO driver telling us that the peer went away, even if we're not running in multi-instance mode. Signed-off-by:    Kristof Provost ---   src/openvpn/for

Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-26 Thread Arne Schwabe
Am 26.04.22 um 18:29 schrieb Kristof Provost via Openvpn-devel: From: Kristof Provost Handle the DCO driver telling us that the peer went away, even if we're not running in multi-instance mode. Signed-off-by: Kristof Provost --- src/openvpn/forward.c | 6 ++ 1 file changed, 6 insertio

[Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode

2022-04-26 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Handle the DCO driver telling us that the peer went away, even if we're not running in multi-instance mode. Signed-off-by: Kristof Provost --- src/openvpn/forward.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c in