I’ll post a patch.
> - any particular reason you used argv_printf() + argv_printf_cat(),
>instead of just putting all into a single argv_printf() call?
>
Mostly that that’s what src/openvpn/networking_iproute2.c does too. I
don’t have particularly strong feelings either way, so I’ll add that
From: Kristof Provost
Address a few minor code review remarks:
- use constants for the inet_ntop() buffers
- replace argv_printf() + argv_printf_cat() with a single argv_printf()
- net_route_v4/6 both add and remove, so adjust the error message to
reflect that.
Signed-off-by: Kristof Prov
