Re: [Openvpn-devel] [PATCH] Fixed compiler warnings reported on Ubuntu 10.04

2010-09-18 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/09/10 17:18, David Sommerseth wrote: > The warnings reported where: > > misc.c:158: warning: ignoring return value of ‘nice’, declared with attribute > warn_unused_result > options.c:4033:

Re: [Openvpn-devel] [PATCH] Fixed compiler warnings reported on Ubuntu 10.04

2010-09-17 Thread Peter Stuge
David Sommerseth wrote: > The warnings reported where: > > misc.c:158: warning: ignoring return value of ‘nice’, declared with attribute > warn_unused_result > options.c:4033: warning: format not a string literal and no format arguments > op

Re: [Openvpn-devel] [PATCH] Fixed compiler warnings reported on Ubuntu 10.04

2010-09-17 Thread Gert Doering
Hi, On Fri, Sep 17, 2010 at 05:18:55PM +0200, David Sommerseth wrote: > diff --git a/misc.c b/misc.c > index eafd892..1e863f2 100644 ACK. Good programming practice. The format string stuff might be harmless right now (if the input is well-controlled) but might it's still good practice to be exp

[Openvpn-devel] [PATCH] Fixed compiler warnings reported on Ubuntu 10.04

2010-09-17 Thread David Sommerseth
The warnings reported where: misc.c:158: warning: ignoring return value of ‘nice’, declared with attribute warn_unused_result options.c:4033: warning: format not a string literal and no format arguments options.c:4043: warning: format not a