Re: [Openvpn-devel] [PATCH] Fix temporary file leak

2014-10-20 Thread David Sommerseth
On 14/10/14 18:15, David Sommerseth wrote: > On 12/10/14 21:59, Samuel Thibault wrote: >> David Sommerseth, le Fri 10 Oct 2014 12:13:42 +0200, a écrit : >>> I think it would be better to move the unlink() code from >>> multi_client_connect_post() into multi_connection_established(), where >>> these

Re: [Openvpn-devel] [PATCH] Fix temporary file leak

2014-10-14 Thread David Sommerseth
On 12/10/14 21:59, Samuel Thibault wrote: > David Sommerseth, le Fri 10 Oct 2014 12:13:42 +0200, a écrit : >> I think it would be better to move the unlink() code from >> multi_client_connect_post() into multi_connection_established(), where >> these temp files are created. This makes the code cle

Re: [Openvpn-devel] [PATCH] Fix temporary file leak

2014-10-12 Thread Samuel Thibault
David Sommerseth, le Fri 10 Oct 2014 12:13:42 +0200, a écrit : > I think it would be better to move the unlink() code from > multi_client_connect_post() into multi_connection_established(), where > these temp files are created. This makes the code clearer and easier to > understand. Right, how ab

Re: [Openvpn-devel] [PATCH] Fix temporary file leak

2014-10-10 Thread David Sommerseth
On 09/10/14 23:40, Samuel Thibault wrote: > Hello, > > Our openvpn server got out of free inodes in /tmp, making it quite > completely nonworking. This is due to some codepath in multi.c which > does not remove its temporary file (when a plugin callback returns an > error, or a client-connect scr

[Openvpn-devel] [PATCH] Fix temporary file leak

2014-10-09 Thread Samuel Thibault
Hello, Our openvpn server got out of free inodes in /tmp, making it quite completely nonworking. This is due to some codepath in multi.c which does not remove its temporary file (when a plugin callback returns an error, or a client-connect script returns an error). Please see the attached patch