Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread david korczynski
Sounds good, and the rule of committing code sounds good to me! I will be looking to providing more patches based on what the fuzzing finds in the near future. On 19/07/2021 17:11, Gert Doering wrote: ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Pos

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread Gert Doering
Hi, On Mon, Jul 19, 2021 at 04:29:32PM +0100, david korczynski wrote: > Gert and Antonio, I am not sure if you would want me to change the > commit message or not. Let me know if you want me to change it and then > I will do that. Nah, I'll adjust the commit message when commiting. (Our rule is:

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread david korczynski
Gert and Antonio, I am not sure if you would want me to change the commit message or not. Let me know if you want me to change it and then I will do that. On 15/07/2021 10:10, Gert Doering wrote: ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Post Box

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-15 Thread Gert Doering
Hi, On Thu, Jul 15, 2021 at 08:47:13AM +0200, Antonio Quartulli wrote: > On 14/07/2021 18:25, David Korczynski wrote: > > Signed-off-by: David Korczynski > > Some commit message is always good - just to give context to the reader > without the need to look at the rest of the code. > > But if Ge

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-14 Thread Antonio Quartulli
Hi, On 14/07/2021 18:25, David Korczynski wrote: > Signed-off-by: David Korczynski Some commit message is always good - just to give context to the reader without the need to look at the rest of the code. But if Gert is fine without it, I am fine too. > --- > src/openvpn/route.c | 2 ++ > 1 f

[Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-14 Thread David Korczynski
Signed-off-by: David Korczynski --- src/openvpn/route.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 56fa7717..e429e8c0 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1584,6 +1584,7 @@ add_route(struct route_ipv4 *r, i