Re: [Openvpn-devel] [PATCH] Fix format spec errors in Windows builds

2018-02-21 Thread Selva Nair
Hi, On Tue, Feb 20, 2018 at 3:20 AM, Gert Doering wrote: > Hi, > > On Mon, Feb 19, 2018 at 03:26:34PM -0500, selva.n...@gmail.com wrote: >> - In route.c print adapter_index as unsigned int as in the rest >> of the code. > > That one confuses me, but that is most likely me vs. windows types. > >

Re: [Openvpn-devel] [PATCH] Fix format spec errors in Windows builds

2018-02-20 Thread Gert Doering
Hi, On Mon, Feb 19, 2018 at 03:26:34PM -0500, selva.n...@gmail.com wrote: > - In route.c print adapter_index as unsigned int as in the rest > of the code. That one confuses me, but that is most likely me vs. windows types. adapter_index is declared as "DWORD" in tun.h, and https://msdn.mic

[Openvpn-devel] [PATCH] Fix format spec errors in Windows builds

2018-02-19 Thread selva . nair
From: Selva Nair - "%ll" is not supported by Windows run time, so use PRIi64 and cast the variable to (int64_t) in output statements (as suggested by Steffan in patch # 234: https://patchwork.openvpn.net/patch/234/) - Fix an instance of wchar_t * printed using %s -- should be %ls. - C