Re: [Openvpn-devel] [PATCH] Fix SOCKSv5 method selection

2014-04-13 Thread Gert Doering
Hi, On Sun, Apr 13, 2014 at 03:50:45PM +0200, Arne Schwabe wrote: > Am 13.04.14 15:01, schrieb Gert Doering: > > On Sun, Apr 13, 2014 at 01:52:57PM +0200, Gert Doering wrote: > >> I'll amend that when committing. > > Here is the patch with the MSVC build change, plus some changes to the > > commit

Re: [Openvpn-devel] [PATCH] Fix SOCKSv5 method selection

2014-04-13 Thread Arne Schwabe
Am 13.04.14 15:01, schrieb Gert Doering: > Hi, > > On Sun, Apr 13, 2014 at 01:52:57PM +0200, Gert Doering wrote: >> I'll amend that when committing. > Here is the patch with the MSVC build change, plus some changes to the > commit message to point to the pull request and trac. > > ACK from me for t

Re: [Openvpn-devel] [PATCH] Fix SOCKSv5 method selection

2014-04-13 Thread Gert Doering
Hi, On Sun, Apr 13, 2014 at 01:52:57PM +0200, Gert Doering wrote: > I'll amend that when committing. Here is the patch with the MSVC build change, plus some changes to the commit message to point to the pull request and trac. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Fix SOCKSv5 method selection

2014-04-13 Thread Gert Doering
Hi, this came in as github pull req #14, and fixes the socks problem that people are complaining about in about every list, except here and in trac... - there *is* also trac#377. The patch "as is" breaks windows compilation as... > + if (p->authfile[0]) > + method_sel[2] = 0x02; /* METHOD

[Openvpn-devel] [PATCH] Fix SOCKSv5 method selection

2014-04-13 Thread Gert Doering
From: Yawning Angel So, RFC 1928 doesn't say anything about the METHODS field in the Method Selection message being ordered in terms of preference or anything, and the server is free to pick any of the METHODS offered by the client. Always sending a Method Selection message with NO AUTHENTICATIO