Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-16 Thread Gert Doering
Hi, On Thu, Mar 16, 2017 at 03:35:35PM +0800, Antonio Quartulli wrote: > If there is no objection, I'll send a patch for this. Please do. We only check seconds today anyway - plus file size(!), so I'm not really seeing a scenario where a CRL file gets refreshed more than once per second but the

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-16 Thread Antonio Quartulli
On Wed, Mar 15, 2017 at 10:00:47PM +0100, Gert Doering wrote: > > diff --git a/src/openvpn/ssl_openssl.h b/src/openvpn/ssl_openssl.h > > index c64c65f..a974e7e 100644 > > --- a/src/openvpn/ssl_openssl.h > > +++ b/src/openvpn/ssl_openssl.h > > @@ -49,7 +49,11 @@ > >*/ > > struct tls_root_ctx {

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-15 Thread Eric Thorpe
Hi, Patch below with the requested hunks removed. Signed-off by: Eric Thorpe diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in index 4bc89e7..7977cb8 100644 --- a/config-msvc-version.h.in +++ b/config-msvc-version.h.in @@ -1,8 +1,12 @@ #define PACKAGE_NAME "@PRODUCT_NAME@" -#de

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-15 Thread Steffan Karger
Hi, On 15-03-17 22:00, Gert Doering wrote: > On Tue, Mar 14, 2017 at 09:26:52AM +1100, Eric Thorpe wrote: >> #ifdef HAVE_CONFIG_MSVC_LOCAL_H >> #include >> diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c >> index 5549d70..bed39f3 100644 >> --- a/src/openvpn/crypto_ope

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-15 Thread Gert Doering
Hi, thanks for your patch. I'm not exactly happy with it for a number of reasons, but it's a good way to get started. Details... On Tue, Mar 14, 2017 at 09:26:52AM +1100, Eric Thorpe wrote: [..] > diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in > index 4bc89e7..7977cb8 100644 >

[Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-13 Thread Eric Thorpe
This patch enables the building of OpenVPN for the 2.4 and master branches using MSVC (Visual Studio 2013 / MSVC v120), which currently doesn't work with 2.4 or a clone of master. 2013 is being used as it reduces the complexity of the redistributable requirements and has mostly complete C99 sup