Re: [Openvpn-devel] [PATCH] Document/cleanup event_timeout functions

2022-10-06 Thread Arne Schwabe
Am 23.09.22 um 12:12 schrieb Frank Lichtenheld: bool event_timeout_trigger(struct event_timeout *et, struct timeval *tv, - const int et_const_retry); + int et_const_retry); Why remove the const here? You did n

Re: [Openvpn-devel] [PATCH] Document/cleanup event_timeout functions

2022-09-23 Thread Frank Lichtenheld
On Fri, Sep 23, 2022 at 10:58:04AM +0200, Arne Schwabe wrote: > Remove function event_timeout_clear_ret as it is unused. > > Cleanup event_timeout_trigger a bit. Do an instant return false if the > timeout is not defined and inline local_now and use > event_timeout_remaining instead of local dupli

[Openvpn-devel] [PATCH] Document/cleanup event_timeout functions

2022-09-23 Thread Arne Schwabe
Remove function event_timeout_clear_ret as it is unused. Cleanup event_timeout_trigger a bit. Do an instant return false if the timeout is not defined and inline local_now and use event_timeout_remaining instead of local duplicated code. Add doxygen comments for all timeout function, especially f