Re: [Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Gert Doering
Hi, On Fri, Nov 13, 2015 at 10:34:49AM -0500, Selva Nair wrote: > On Fri, Nov 13, 2015 at 10:27 AM, Gert Doering wrote: > >> However, if the user specifies --win-sys some_cruft, win_sys_path will > >> get set to that "some_cruft" (in options.c). User is the king. > > > > Yes. In this case, I do

Re: [Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Selva Nair
Hi, On Fri, Nov 13, 2015 at 10:27 AM, Gert Doering wrote: >> >> However, if the user specifies --win-sys some_cruft, win_sys_path will >> get set to that "some_cruft" (in options.c). User is the king. > > Yes. In this case, I do not worry at all - "you get what you ask for". In the current setu

Re: [Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Gert Doering
Hi, On Fri, Nov 13, 2015 at 10:21:12AM -0500, Selva Nair wrote: > > OTOH, I'm not sure if this is going to work - win_sys_path is (unless > > set from options.c) initialized via > > > > GetEnvironmentVariable (SYS_PATH_ENV_VAR_NAME, buf, sizeof(buf) > > set_win_sys_path (buf, es); > > > > ...

Re: [Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Selva Nair
On Fri, Nov 13, 2015 at 2:38 AM, Gert Doering wrote: > Hi, > > On Thu, Nov 12, 2015 at 09:41:27PM -0500, Selva Nair wrote: >> FWIW, fixes trac #500 >> >> Signed-off-by: Selva Nair >> --- >> src/openvpn/win32.c | 7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> ... > Cool :-) > > T

Re: [Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Gert Doering
Hi, On Thu, Nov 12, 2015 at 09:41:27PM -0500, Selva Nair wrote: > FWIW, fixes trac #500 > > Signed-off-by: Selva Nair > --- > src/openvpn/win32.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c > index 7c89a5a..d06b41f 10

[Openvpn-devel] [PATCH] Do not hard-code windows systemroot in env_block

2015-11-13 Thread Selva Nair
FWIW, fixes trac #500 Signed-off-by: Selva Nair --- src/openvpn/win32.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c index 7c89a5a..d06b41f 100644 --- a/src/openvpn/win32.c +++ b/src/openvpn/win32.c @@ -763,7 +763,12 @@ win_s