Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-13 Thread Gert Doering
Hi, On Fri, Aug 12, 2016 at 11:39:22PM +0200, David Woodhouse wrote: > Yeah, I once made git use strftime("%z") but that is... handled > differently now. > >         time(&now); > > offset = tm_to_time_t(localtime(&now)) - now; > offset /= 60; > > Where tm_to_time_t() is basical

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-12 Thread David Woodhouse
On Fri, 2016-08-12 at 23:02 +0200, Gert Doering wrote: > This is a good argument.  Unfortunately, it's a surprisingly *hairy* one, > as there are time zones that do not have a full-hour offset - so ISO 8601 > (according to wikipedia) says you should do "±hh:mm" then - and for > most folks, ":mm" wo

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-12 Thread Gert Doering
Hi, On Fri, Aug 12, 2016 at 09:53:34PM +0200, David Woodhouse wrote: > On Thu, 2016-08-11 at 21:23 +0200, Gert Doering wrote: > > All our timestams used to be "what ctime()" produces, which is > > > >   "Thu Aug 11 21:15:27 2016" > > > > Changed to use POSIX standard format, which is > > > >  

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-12 Thread David Woodhouse
On Thu, 2016-08-11 at 21:23 +0200, Gert Doering wrote: > All our timestams used to be "what ctime()" produces, which is > >   "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > >   "2016-08-11 21:15:27" While you're at it, perhaps also add the timezone in numeric (±

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-12 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/08/16 21:23, Gert Doering wrote: > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > > "2016-08-11 21:15:27" > > this applies to logging (except

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Илья Шипицин
iso 8601 is good format. it is accepted by default by sql servers, Log Parser 2016-08-12 0:23 GMT+05:00 Gert Doering : > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > > "2016-08-11 21:15:27"

[Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Gert Doering
All our timestams used to be "what ctime()" produces, which is "Thu Aug 11 21:15:27 2016" Changed to use POSIX standard format, which is "2016-08-11 21:15:27" this applies to logging (except to syslog or if --machine-readable-ouput is used) and to various other places where informational ti