Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-12 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/16 00:58, Selva Nair wrote: > - Replace %zu by %u and cast the size_t variable to (unsigned int). > The cast should be safe as in all instances the number involved is > small. > > Note: mingw64 targets msvcrt.dll runtime that doesn't support

[Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
- Replace %zu by %u and cast the size_t variable to (unsigned int). The cast should be safe as in all instances the number involved is small. Note: mingw64 targets msvcrt.dll runtime that doesn't support %zu and print "zu" instead of the number. With -Wformat the compiler does warn t

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
On Thu, Aug 11, 2016 at 1:30 PM, Gert Doering wrote: > sorry for being a bit lazy in answering. This is the sort of threads > that lead to endless wars ... :-) > Oh, no, this one is not worth even a fist fight, forget wars :) > > On Sun, Aug 07, 2016 at 10:47:16AM -0400, Selva Nair wrote: > >

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Gert Doering
Hi, sorry for being a bit lazy in answering. This is the sort of threads that lead to endless wars ... :-) On Sun, Aug 07, 2016 at 10:47:16AM -0400, Selva Nair wrote: > > I looked into this a bit, and it should indeed fix the printing of %zu > > on Windows. I would prefer to teach autotools to

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-11 Thread Selva Nair
On Sun, Aug 7, 2016 at 10:47 AM, Selva Nair wrote: > Hi, > > On Sun, Aug 7, 2016 at 10:04 AM, Steffan Karger wrote: > >> On 5 August 2016 at 15:09, Selva Nair wrote: >> > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger >> wrote: >> >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering >> wrote: >> >

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-07 Thread Selva Nair
Hi, On Sun, Aug 7, 2016 at 10:04 AM, Steffan Karger wrote: > On 5 August 2016 at 15:09, Selva Nair wrote: > > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger > wrote: > >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering > wrote: > >> > On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: >

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-07 Thread Steffan Karger
On 5 August 2016 at 15:09, Selva Nair wrote: > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger wrote: >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering wrote: >> > On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: >> >> - msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for crypto by %zu

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-05 Thread Selva Nair
On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger wrote: > Hi, > > On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering wrote: > > On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: > >> - msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for crypto by %zu > bytes", > >> - __func__, crypto_ov

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-05 Thread Gert Doering
Hi, On Fri, Aug 05, 2016 at 09:32:35AM +0200, Steffan Karger wrote: > MSVC 2015 claims to support C99 now (took them 16 years!), and it > should at least support %zu (which is part of C99). Shouldn't we just > move (at least the master branch) to C99? Or are there good reasons > to keep punishin

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-05 Thread Steffan Karger
Hi, On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering wrote: > On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: >> - msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for crypto by %zu bytes", >> - __func__, crypto_overhead); >> + msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for c

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-05 Thread Gert Doering
Hi, On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: > - msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for crypto by %zu bytes", > - __func__, crypto_overhead); > + msg(D_MTU_DEBUG, "%s: Adjusting frame parameters for crypto by %d bytes", > + __func__, (int) crypto_overhe

[Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-05 Thread Selva Nair
Signed-off-by: Selva Nair --- src/openvpn/crypto.c |4 ++-- src/openvpn/options.c |4 ++-- src/openvpn/ssl_mbedtls.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c index d94896c..1236eae 100644 --- a/src/ope