Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-03 Thread Gert Doering
Hi, On Tue, Jan 03, 2017 at 02:36:47PM -0500, Selva Nair wrote: > > Agreed. Will send a v2 later today. > > There is one corner case that I realized only now: what > happens when a real dhcp server is in use (say in bridge mode). > Current dhcp_release() function is a no-op unless the > masquerad

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-03 Thread Selva Nair
On Tue, Jan 3, 2017 at 12:55 PM, Selva Nair wrote: > Hi, > > On Tue, Jan 3, 2017 at 12:17 PM, Gert Doering wrote: > >> On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: >> > From: Selva Nair >> > >> > Also make sure --dhcp-pre-release results in not just dhcp_release() >> >

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-03 Thread Selva Nair
Hi, On Tue, Jan 3, 2017 at 12:17 PM, Gert Doering wrote: > On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Also make sure --dhcp-pre-release results in not just dhcp_release() > > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp >

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-03 Thread Gert Doering
Hi, On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > Also make sure --dhcp-pre-release results in not just dhcp_release() > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction > gets aborted as this call to release() happens afte

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-03 Thread debbie10t
On 01/01/17 18:15, Selva Nair wrote: > Hi, > > On Sun, Jan 1, 2017 at 10:49 AM, debbie10t wrote: > >> Hi, >> >> I applied this to 2.5 and used the build system to build windows >> installer using windows-nsis/build-snapshot >> >> I tested the windows client against Linux 2.4 >> >> The test was:

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Selva Nair
Hi, On Sun, Jan 1, 2017 at 10:49 AM, debbie10t wrote: > Hi, > > I applied this to 2.5 and used the build system to build windows > installer using windows-nsis/build-snapshot > > I tested the windows client against Linux 2.4 > > The test was: > > Connect to first server, receive DHCP 10.*8*.0.6

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Selva Nair
Hi, On Sun, Jan 1, 2017 at 8:35 AM, Gert Doering wrote: > > Now, for this particular patch, I'm a bit undecided - it fixes breakage > for people, but there's a warning about "unexpected side effects" so > we might try to figure out why this warning exist. Less options and > doing the right thin

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread debbie10t
Hi, I applied this to 2.5 and used the build system to build windows installer using windows-nsis/build-snapshot I tested the windows client against Linux 2.4 The test was: Connect to first server, receive DHCP 10.*8*.0.6 (net30) Idle 10 mins / Transfer some data / disconnect Edit the config

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Gert Doering
Hi, On Sun, Jan 01, 2017 at 01:22:37PM +, debbie10t wrote: > Should this be applied to 2.4.0 or 2.5_gitmaster ? Generally speaking, everything goes to git master (unless specifically tagged as "this is for 2.3 / 2.4"). From there, bugfixes, long-term compatibility changes, and in some cases

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread debbie10t
Should this be applied to 2.4.0 or 2.5_gitmaster ? thanks On 31/12/16 02:45, selva.n...@gmail.com wrote: > From: Selva Nair > > Also make sure --dhcp-pre-release results in not just dhcp_release() > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction > gets aborted as this

[Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2016-12-30 Thread selva . nair
From: Selva Nair Also make sure --dhcp-pre-release results in not just dhcp_release() in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction gets aborted as this call to release() happens after the adapter status is changed to connected. Alternatively, the undocumented --dhcp