Hi,
On Thu, Apr 21, 2022 at 02:41:18PM +0200, Heiko Hund wrote:
> > Especially this one is something I only noticed after I sent my mail -
> > so this definitely needs to to mktemp-style temp files, or a private
> > tmp directory (in the local repo?)
>
> I don't really see the need for secure tmp
Hi Frank
On Donnerstag, 21. April 2022 10:01:29 CEST Frank Lichtenheld wrote:
> > +# If called so, install this script as pre-commit hook
> > +if [ "$1" = "install" ] ; then
> > +ROOTDIR=$(git rev-parse --show-toplevel)
> > +HOOKSDIR="$ROOTDIR/.git/hooks"
>
> Actually, the correct way to
Hi David
On Donnerstag, 21. April 2022 13:41:58 CEST David Schneider wrote:
> Did you consider to use the pre-commit framework [1] written in
> Python? There is a maintained hook for uncrustify [2].
> This would allow it to easily integrate other linters/checks. See the
> list of supported hooks [
Hi
On Donnerstag, 21. April 2022 10:16:03 CEST Gert Doering wrote:
> On Thu, Apr 21, 2022 at 10:01:29AM +0200, Frank Lichtenheld wrote:
> > Definitive NACK due to licensing concern mentioned below.
>
> Streams crossed here, but I saw your NAK before pushing.
> So, yes, all valid concerns and I wi
Hi all,
Did you consider to use the pre-commit framework [1] written in
Python? There is a maintained hook for uncrustify [2].
This would allow it to easily integrate other linters/checks. See the
list of supported hooks [3].
I would understand if you don't like to add yet another dependency,
but
Hi,
On Thu, Apr 21, 2022 at 10:01:29AM +0200, Frank Lichtenheld wrote:
> Definitive NACK due to licensing concern mentioned below.
Streams crossed here, but I saw your NAK before pushing.
So, yes, all valid concerns and I withdraw my ACK.
> [...]
> > +# create a filename to store our generated
Definitive NACK due to licensing concern mentioned below.
> Heiko Hund hat am 21.04.2022 01:31 geschrieben:
>
>
> The script is self installing if you call it with "install" as the first
> parameter. Once installed as the pre-commit hook it will check files to
> be committed according to the r
The script is self installing if you call it with "install" as the first
parameter. Once installed as the pre-commit hook it will check files to
be committed according to the rules in uncrustify.conf and abort the
commit if there's formatting issues. The script produces a patch in /tmp
which can be
