Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.1_rc16 released

2009-05-21 Thread David Sommerseth
> You also forgot the following patch. > This avoid clash with MS constant, exists in psdk and mingw64. > Instead of #undef it, use another name. > +1 to this patch. If there is a conflict with one platform, it's far better to use another #define name instead, IMHO. kind regards, David Sommer

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.1_rc16 released

2009-05-20 Thread Alon Bar-Lev
On 5/20/09, Alon Bar-Lev wrote: > On 5/20/09, James Yonan wrote: > >5. In cryptoapi.c, renamed CryptAcquireCertificatePrivateKey to > > OpenVPNCryptAcquireCertificatePrivateKey to work around > > a symbol conflict in MinGW-5.1.4. > > > Too much rename. > Please revert at GetPr

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.1_rc16 released

2009-05-20 Thread Alon Bar-Lev
On 5/20/09, James Yonan wrote: >5. In cryptoapi.c, renamed CryptAcquireCertificatePrivateKey to > OpenVPNCryptAcquireCertificatePrivateKey to work around > a symbol conflict in MinGW-5.1.4. Too much rename. Please revert at GetProcAddress and ERR_PACK.