Re: [Openvpn-devel] [PATCH applied] Don't let openvpn_popen() keep zombies around

2014-09-09 Thread davids
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit d886d468849051af525bb8ff1b9080f6c934e3ab Author: David Sommerseth List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Sep 5 14:26:32 2014 +0200 Don't let o

[Openvpn-devel] [PATCH 3/4] Clean up the pipe closing in openvpn_popen()

2014-09-05 Thread davids
From: David Sommerseth Do the proper closing of the pipe ends which is not being used, also in error situations. Moved the closing of the parent side before the waitpid(), to be consistent with the child side (as early as possible). Also improved the error messages with more details. Signed-of

[Openvpn-devel] [PATCH 2/4] Don't try to use systemd-ask-password if it is not available

2014-09-05 Thread davids
From: David Sommerseth If the SYSTEMD_ASK_PASSWORD_PATH executable cannot be found, we don't consider systemd as running. Also cleaned up some white-space issues here while at it. Signed-off-by: David Sommerseth --- src/openvpn/console.c | 11 ++- 1 file changed, 6 insertions(+), 5 de

[Openvpn-devel] [PATCH 1/4] Don't let openvpn_popen() keep zombies around

2014-09-05 Thread davids
From: David Sommerseth Commit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the openvpn_popen() function to support retrieving passwords via systemd. It was discovered that the child processes openvpn fork()ed would be lingering around until openvpn stopped. This was due to the lack of a

[Openvpn-devel] [PATCH 4/4] White-space clean-up of openvpn_popen()

2014-09-05 Thread davids
From: David Sommerseth The whole coding style was a mishmash of tab/spaces and different alignments. Reformatted to 2 space indents (no tabs). Signed-off-by: David Sommerseth --- src/openvpn/misc.c | 81 +++--- 1 file changed, 41 insertions(+),

[Openvpn-devel] [PATCH 0/4] Clean-up of the systemd integration

2014-09-05 Thread davids
From: David Sommerseth There were a few issues with the systemd implementation, where the openvpn binary would have zombie processes attached to itself when systemd-ask-password was used. In addition to not always properly closing the communcation pipes used. This patch set also avoids OpenVPN

Re: [Openvpn-devel] [PATCH applied] Add configure check for the path to systemd-ask-password

2014-09-05 Thread davids
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit ba79c71d1255651bfcb8570519b4033c763d47d3 Author: Mike Gilbert List-Post: openvpn-devel@lists.sourceforge.net Date: Thu Jul 3 16:24:05 2014 -0400 Add configure c

[Openvpn-devel] [PATCH] Don't let openvpn_popen() keep zoombies around

2014-09-03 Thread davids
From: David Sommerseth Commit 9449e6a9eba30c9ed054f57d630a88c9f087080f introduced the openvpn_popen() function to support retrieving passwords via systemd. It was discovered that the child processes openvpn fork()ed would be lingering around until openvpn stopped. This was due to the lack of a

[Openvpn-devel] [PATCH] Improve error reporting on file access to --client-config-dir and --ccd-exclusive

2014-04-16 Thread davids
From: David Sommerseth OpenVPN will do some simple sanity checking at startup to ensure the expected files and directories is in place. However, with --client-config-dir and --ccd-exclusive, things are slightly different. In both cases it is perfectly fine that files does not exists, and we can

[Openvpn-devel] [PATCH] Adjusted autotools files to build more cleanly on newer autoconf/automake versions

2014-01-15 Thread davids
From: David Sommerseth Signed-off-by: David Sommerseth --- configure.ac| 8 src/openvpn/Makefile.am | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 636d4e2..ec8b96b 100644 --- a/configure.ac +++ b/configure.ac @@ -680