Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Yegor Yefremov
On Thu, May 28, 2015 at 4:00 PM, Gert Doering wrote: > Hi, > > On Thu, May 28, 2015 at 02:21:44PM +0200, Yegor Yefremov wrote: >> On Tue, Apr 21, 2015 at 9:58 AM, Vasily Kulikov wrote: >> > On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: >

Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Yegor Yefremov
Hi Gert, On Tue, Apr 21, 2015 at 9:58 AM, Vasily Kulikov wrote: > On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: >> Release pCertName, if SecCertificateCopyValues() fails. >> >> Found via cppcheck. >> >> Signed-off-by: Yegor Yefremov >> C

[Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-04-20 Thread Yegor Yefremov
Release pCertName, if SecCertificateCopyValues() fails. Found via cppcheck. Signed-off-by: Yegor Yefremov Cc: Vasily Kulikov --- contrib/keychain-mcd/cert_data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/keychain-mcd/cert_data.c b/contrib/keychain-mcd/cert_data.c index

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-14 Thread Yegor Yefremov
On Tue, Apr 14, 2015 at 10:48 PM, Gert Doering wrote: > Hi, > > On Tue, Apr 14, 2015 at 08:34:05PM +0200, Yegor Yefremov wrote: >> +# enable silent build >> +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes]])) >> + > > I don't understand autoconf magic well

[Openvpn-devel] [PATCH] m4: enable silent build

2015-04-14 Thread Yegor Yefremov
Signed-off-by: Yegor Yefremov --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 9132468..ca0d9c3 100644 --- a/configure.ac +++ b/configure.ac @@ -374,6 +374,9 @@ AC_DEFINE_UNQUOTED([IPROUTE_PATH], ["$IPROUTE"], [Path to ip

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-23 Thread Yegor Yefremov
On Sat, Nov 22, 2014 at 12:57 PM, Gert Doering wrote: > Hiya, > > On Sat, Nov 22, 2014 at 11:47:05AM +0100, Arne Schwabe wrote: >> Almost anybody always turns this feature on, at least all distribution >> have it on. > > Which is indeed a strong argument for removing the conditional... maybe > qui

[Openvpn-devel] [PATCH] polarssl: fix unreachable code

2014-11-23 Thread Yegor Yefremov
Found via cppcheck and compile-tested. Signed-off-by: Yegor Yefremov --- src/openvpn/ssl_polarssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ssl_polarssl.c b/src/openvpn/ssl_polarssl.c index b026a17..2036885 100644 --- a/src/openvpn/ssl_polarssl.c +++ b

[Openvpn-devel] [PATCH] socket: remove duplicate expression

2014-11-22 Thread Yegor Yefremov
Found via cppcheck and compile-tested. Signed-off-by: Yegor Yefremov --- src/openvpn/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 29f9958..331a9d9 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-21 Thread Yegor Yefremov
On Fri, Nov 21, 2014 at 8:40 PM, Yegor Yefremov wrote: > Set enable_password_save to "yes", if the option is not given, > as stated in the description. > > Signed-off-by: Yegor Yefremov > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-21 Thread Yegor Yefremov
Set enable_password_save to "yes", if the option is not given, as stated in the description. Signed-off-by: Yegor Yefremov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 608ab6d..9dcd2ab 100644 --- a/configur