Re: [Openvpn-devel] [PATCH] Fix autotools check for res_init

2015-03-06 Thread Nicholas Hall
Hello! > We use getaddrinfo() and getnameinfo() extensively, which do not require > res_init() to be called first... > > So, instead of adding more convolutions to configure.ac, I propose to > throw out res_init() and everything related to it :-) - much easier. res_init seems to be necessary to p

[Openvpn-devel] [PATCH] Fix autotools check for res_init

2015-03-06 Thread Nicholas Hall
Autotools configure check fails to detect res_init on recent glibc versions. It appears that resolv.h in recent glibc maps res_init to __res_init which autotools doesn't catch. This is my first patch ever to anything autotools related. I used the check that the ntpd uses and tested on Debian 8 x

[Openvpn-devel] [PATCH] Properly quote command and arguments passed to system() in down-root

2013-10-21 Thread Nicholas Hall
Via GitHub Pull Request https://github.com/OpenVPN/openvpn/pull/9 Attached patch file for convenience -- Suppose the following command: openvpn --config config \ --plugin /usr/lib/openvpn/openvpn-plugin-down-root.so "bash -c \"script_type=down

[Openvpn-devel] [PATCH] Add timeout option for socks proxies

2013-08-22 Thread Nicholas Hall
>From https://github.com/OpenVPN/openvpn/pull/1 (I am not the patch author) This patch adds a socks-proxy-timeout option. Defaults to 5 seconds which is the hardcoded value in master right now. I updated the patch slightly to merge successfully against master. 0001-Add-timeout-option-for-socks

[Openvpn-devel] tls_ctx_load_ca: Improve certificate error messages

2013-08-22 Thread Nicholas Hall
>From https://github.com/OpenVPN/openvpn/pull/4 (I am not the patch author) If a CA certificate file includes intermediate certificates, and any of them fail to verify, the current code will file with "Cannot load CA certificate file". Instead, generate a more specific error message identifying th

Re: [Openvpn-devel] [Openvpn-users] pull requests on github

2013-08-21 Thread Nicholas Hall
Do you need a middle man to monitor github and forword patches to the devel mailing list along with commenting back and forth between github? I'm not well versed in compiled languages but I am no stranger to basic code review and developer interactions. I'd volunteer if you need someone to do thi