Yes, your right, there is this one "debugging" line left
(it was just to be sure, the setting of auth_user_pass_file to "stdin"
is the first thing done).
Original-Nachricht
Betreff: Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass
Von: D
Hi Davide,
I had some time today, so I did some changes ("improvements", I hope
;-)) to your code:
First thing you do in add_option() if inline is used: auth_pass_file is
set (to "stdin").
So there is no need to check for both (options->auth_user_pass_file ||
options->auth_user_pass_file_inline),
cannot be in a file if using
--static-challenge");
+#endif
[...]
A quick test did work with and without user authentication (only tested inline
settzing, not with a file).
Joerg
Original-Nachricht
Gesendet: Samstag, 05. Oktober 2013 um 15:57 Uhr
Von: "Max Muster"
oops, just took my "debug" version of src/openvpn/ssl.c ...
Of course output of string length and especially password in log file is
not intended ;-)
Joerg
Original-Nachricht
Betreff: Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass
Von: max.mus...@kaffeeschluerfe
Hi Davide,
nice idea. But I think I found two small bugs:
First, it won't compile in a config w/o ENABLE_CLIENT_CR defined (there is no "sc_info").
Second, if I'm not mistaken, name and password are not copied correctly:
If # of charachters is (pos - prev), the last charakter is at [pos - pre
Sorry, my fault, didn't realize bug reports were already "merged".
Joerg
Gesendet: Montag, 16. September 2013 um 11:29 Uhr
Von: max.mus...@kaffeeschluerfer.com
An: "Josh Cepek"
Cc: openvpn-devel@lists.sourceforge.net
Betreff: Re: [Openvpn-devel] [PATCH] Fix file access checks when using --
Did not look into the patch in detail, but it should fix bug #299, too.
Hopfully this will get some more response than my approach there ;-)
Regards
Joerg
Gesendet: Sonntag, 15. September 2013 um 11:42 Uhr
Von: "Josh Cepek"
An: openvpn-devel@lists.sourceforge.net
Betreff:
Dear list,
may I ask for your attention or feedback on the faulty file checking if
"chroot" option is enabled?
The "check_file_access" in src/openvpn/options.c will check for the
existence of the "client-config-dir".
This fails if used in conjunction with the "chroot" option, because the
path in
Hi Gert,
schrieb Gert Doering:
> Hi,
>
> On Sun, Jun 30, 2013 at 08:00:39PM +0200, Max Muster wrote:
>> please forgive me if I'm wrong, but there seems quite "little activity"
>> on bug tracking page from the developers.
>> E.g. one month ago I opened
Hi all,
please forgive me if I'm wrong, but there seems quite "little activity"
on bug tracking page from the developers.
E.g. one month ago I opened a bug report for a (suspected) bug present
in file checking (bug #299) which is still "new" and even not commented.
I don't want to be rude, but I
10 matches
Mail list logo
