Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-30 Thread Holger Kummert
Am 30.10.2015 um 14:58 schrieb Steffan Karger: Hi Holger, On Fri, Oct 30, 2015 at 2:34 PM, Holger Kummert wrote: static void -add_security_buffer(int sb_offset, void *data, int length, unsigned char *msg_buf, int *msg_bufpos) +add_security_buffer(int sb_offset, void *data, int length

Re: [Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2015-10-30 Thread Holger Kummert
w-up patch to fix it later on. It would be highly appreciated if you could give that patch a test spin for me. Hmm, setting up an environment for testing is a bit lengthy. But let's see ... On 04-07-14 09:35, Holger Kummert wrote: + const char

Re: [Openvpn-devel] [PATCH] Del ipv6 addr on close of linux tun interface

2015-06-26 Thread Holger Kummert
Hello, Am 26.06.2015 um 13:24 schrieb Gert Doering: And I actually *do* test for this in one of my t_client test runs... :-) openvpn --client ... --nobind --comp-lzo --verb 3 --dev tun3 --proto tcp6-client --remote conn-test-server.openvpn.org --port 51194 --server-poll-timeout 10 ... and i

Re: [Openvpn-devel] [PATCH] Del ipv6 addr on close of linux tun interface

2015-06-26 Thread Holger Kummert
Hello, Am 26.06.2015 um 16:36 schrieb Gert Doering: Hi, On Fri, Jun 26, 2015 at 01:24:02PM +0200, Gert Doering wrote: This is more wondering about what we *should* do for persistant tun interfaces... (and, now, why your tun ifs behave that way even if they are not actually persistant :) ).

Re: [Openvpn-devel] [PATCH] Del ipv6 addr on close of linux tun interface

2015-06-26 Thread Holger Kummert
Hello Gert, Am 26.06.2015 um 09:35 schrieb Gert Doering: Hi, On Thu, Jun 25, 2015 at 06:01:20PM +0200, Holger Kummert wrote: When a linux tun interface is closed (e.g. on disconnect) an optional ipv6 addr that was previously set is deleted now. Without this patch a later reconnect would fail

[Openvpn-devel] [PATCH] Del ipv6 addr on close of linux tun interface

2015-06-25 Thread Holger Kummert
When a linux tun interface is closed (e.g. on disconnect) an optional ipv6 addr that was previously set is deleted now. Without this patch a later reconnect would fail with 'Linux ip -6 addr add failed: external program exited with error status: 2' and openvpn would exit. --- src/openvpn/tun.c |

Re: [Openvpn-devel] [PATCH 1/2] Get NTLMv1 and NTLMv2 up and running

2014-07-10 Thread Holger Kummert
Hello, Am 04.06.2014 16:05, schrieb Holger Kummert: Is this used - and thus tested - by you only, or is it used by UTM customers? (This would give us confidence that it's tested by a larger user base, and those tend to uncover issues :-) ). Well, I thought I let it pass through the r

[Openvpn-devel] [PATCHv2 1/2] Get NTLMv1 and NTLMv2 up and running

2014-07-04 Thread Holger Kummert
* Force conversion to UTF-16 of username and domain if server requires UTF-16. * Rewrite conversion function to cleanly convert UTF-8 to UTF-16. * Fix bug in length computation in NTLMv2-code. * Architecture independent access to NTLM NegotiateFlags. Signed-off-by: Holger Kummert

Re: [Openvpn-devel] Wanted: NTLM-Testers

2014-06-24 Thread Holger Kummert
Hello David, thanks for taking time and reviewing and testing the code. Am 23.06.2014 16:23, schrieb David Woodhouse: Looking over the patches first... they make the client work in OEM or Unicode mode according to what the server asks for... but then only ever admit to supporting Unicode mode

Re: [Openvpn-devel] [PATCH 1/2] Get NTLMv1 compatibilities and NTLMv2 up and running

2014-06-24 Thread Holger Kummert
So the vote goes clearly to #defines, right? I'm going to change the code and test it. If it works, the change will be included in the next patch. Best regards, Holger Am 18.06.2014 23:07, schrieb David Sommerseth: I see and understands the arguments for using static const, and it surely ha

Re: [Openvpn-devel] [PATCH 1/2] Get NTLMv1 and NTLMv2 up and running

2014-06-18 Thread Holger Kummert
-safe - It respects scope - It eases (in some cases) debugging (entry in symbol table) It is usually recommended as "static const", what we could also use. Am 04.06.2014 16:05, schrieb Holger Kummert: >>+ const unsigned int uni_max_utf16 = 0x0010, >>+

Re: [Openvpn-devel] [PATCH 1/2] Get NTLMv1 and NTLMv2 up and running

2014-06-04 Thread Holger Kummert
code less ugly"? Roughly: The changes in ntlm.c (PATCH 1) belong to "fix the not working", and all other files (PATCH 2) are related to "improve code and configuration". More questions and some comments on style intermixed below... On Wed, Apr 16, 2014 at 12:48:36PM

[Openvpn-devel] Wanted: NTLM-Testers

2014-06-02 Thread Holger Kummert
patches already tested them, but a second proof that they really work would be very helpful. The patches, based on the master branch, can be found at: http://thread.gmane.org/gmane.network.openvpn.devel/8531 Thanks, Holger Kummert Am 19.04.2014 12:56, schrieb Jan Just Keijser: Hi, On 18/04

Re: [Openvpn-devel] Fixes for HTTP proxy authentication with NTLM

2014-04-16 Thread Holger Kummert
Hello, Am 16.04.2014 15:56, schrieb Gert Doering: Hi, On Wed, Apr 16, 2014 at 12:48:35PM +0200, Holger Kummert wrote: Any opinions? First of all, a big thank you for taking this on :-) - there have been you're welcome! a couple of bugs in our trac related to NTLM, but since none o

[Openvpn-devel] [PATCH 2/2] http-proxy: Separate settings for user interaction and authentication auto-behavior

2014-04-16 Thread Holger Kummert
teraction. The other modes remain at one round of interaction. Signed-off-by: Holger Kummert --- doc/openvpn.8 | 22 +++-- src/openvpn/init.c| 3 +- src/openvpn/options.c | 88 +-- src/openvpn/proxy.c | 56

[Openvpn-devel] [PATCH 1/2] Get NTLMv1 and NTLMv2 up and running

2014-04-16 Thread Holger Kummert
* Force conversion to UTF-16 of username and domain if server requires UTF-16. * Rewrite conversion function to cleanly convert UTF-8 to UTF-16. * Fix bug in length computation in NTLMv2-code. * Architecture independent access to NTLM NegotiateFlags. Signed-off-by: Holger Kummert --- src

[Openvpn-devel] Fixes for HTTP proxy authentication with NTLM

2014-04-16 Thread Holger Kummert
Hello, one of our customers reported that the NTLM authentication of OpenVPN doesn't work. I checked that and found that both NTLM versions didn't work against a Win2008 server. The configuration seemed a bit confusing because an 'auth-method' could only be set if an 'authfile' was given (ok, 's