Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-26 Thread Eric Thorpe
leave it to the repo maintainers from here whether they wish to use this patch as is, modify it to their needs or NAK it for a better future solution. I will keep an eye out for a new patch and assist in it's testing if someone wishes to improve upon this. Cheers, Eric --- Er

Re: [Openvpn-devel] [PATCH] Adds client-auth-pending-extra management functionality.

2020-08-26 Thread Eric Thorpe
using this new method would also end up in the above repo. Regards, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com On 26/08/2020 6:55 pm, Arne Schwabe wrote: Am 26.08.20 um 03:15 schrieb Eric Thorpe: Hi Arne, I'm happy

Re: [Openvpn-devel] [PATCH] Adds client-auth-pending-extra management functionality.

2020-08-25 Thread Eric Thorpe
needs further changes. Thanks, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com On 25/08/2020 5:25 pm, Arne Schwabe wrote: Am 25.08.20 um 01:58 schrieb Eric Thorpe: Hi Arne, - to avoid the 256 byte management limit and mul

Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-25 Thread Eric Thorpe
enuinely want their users to reauth manually each period via a renegotiation, so we feel this should be fixed. We've had this patch available as-is now for over a year and have had no reports of issues with it for those using it. Regards, Eric --- Eric Thorpe SparkLabs Developer h

Re: [Openvpn-devel] [PATCH] Adds client-auth-pending-extra management functionality.

2020-08-24 Thread Eric Thorpe
also what IV_SSO flag indicates this authentication method. Are you suggesting that I do not use CR_TEXT, and instead introduce a new Challenge Response type (CR_DATA for example)? Cheers, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@spa

Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-24 Thread Eric Thorpe
r up the call chain so the context_2 is passed to each of these functions instead of just multi & session, however this is about a 500 line refactor that I really don't want to do. Cheers, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparkl

Re: [Openvpn-devel] [PATCH] Adds client-auth-pending-extra management functionality.

2020-08-24 Thread Eric Thorpe
le it without adding further complexity internally to OpenVPN. Cheers, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com On 22/08/2020 7:12 pm, Arne Schwabe wrote: Am 21.08.20 um 08:24 schrieb Eric Thorpe: This allows extra INF

Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-24 Thread Eric Thorpe
oesn't help. The mda_context flags are only set when --management-client-auth is in use, meaning this patch would not cover plugin or script authentication, which are the more commonly used, and this patch set specifically addresses plugin authentication. Regards, Eric --- Eric Thorp

[Openvpn-devel] [PATCH] Adds client-auth-pending-extra management functionality.

2020-08-20 Thread Eric Thorpe
This allows extra INFO_PRE mesasges to be sent to a client during an authentication stage. This may be required to send additional challenges, or allow longer messages to be sent by breaking them up and sending in parts. Signed-off-by: Eric Thorpe --- doc/management-notes.txt | 32

[Openvpn-devel] AUTH_PENDING from client-pending-auth query

2020-08-20 Thread Eric Thorpe
moved? Cheers, Eric -- --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Fixes a bug in management_callback_send_cc_message, should be strlen instead of sizeof

2020-08-19 Thread Eric Thorpe
Signed-off-by: Eric Thorpe --- src/openvpn/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index dfa045b0..a785934a 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -312,7 +312,7 @@ management_callback_send_cc_message

Re: [Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-13 Thread Eric Thorpe
Hi Arne, The issue is your state is not accessible from where that boolean needs to be used unless I am missing something? Please advise if I'm mistaken or of another route. Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs

[Openvpn-devel] [PATCH 2/2] Allows a plugin to provide a client_reason for authentication failure

2020-08-13 Thread Eric Thorpe
Signed-off-by: Eric Thorpe --- src/openvpn/ssl_verify.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 8d8531c7..356b30fd 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn

Re: [Openvpn-devel] [PATCH v2 1/2] Send auth fail to client on reneg failure

2020-08-13 Thread Eric Thorpe
Have re-based to master and resent. Cheers, Eric --- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com On 11/08/2020 7:32 pm, Gert Doering wrote: Hi, On Thu, Apr 11, 2019 at 12:07:27PM +1000, Eric Thorpe wrote: This patch relies on

[Openvpn-devel] [PATCH 1/2] Send auth-fail messages to clients on renegotiation failures via auth-token or user-pass expiry

2020-08-13 Thread Eric Thorpe
Signed-off-by: Eric Thorpe --- src/openvpn/multi.c | 2 ++ src/openvpn/push.c | 30 ++ src/openvpn/ssl_common.h | 1 + src/openvpn/ssl_verify.c | 7 +++ 4 files changed, 40 insertions(+) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index

[Openvpn-devel] [PATCH v2 1/2] Send auth fail to client on reneg failure

2019-04-10 Thread Eric Thorpe
password in the case of auth-nocache for example. This also addresses my previous patch for supporting a client reason being rejected. Regards, Eric -- -- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com From bb0fada899a43e48e2ca38358

[Openvpn-devel] [PATCH v2 2/2] Support client reason from auth plugin

2019-04-10 Thread Eric Thorpe
actor-extensions/tree/master/yubikey-u2f-pam-plugin This is version two for this patch and addresses previous inadequacies pointed out. Regards, Eric -- -- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com

Re: [Openvpn-devel] [PATCH v2 3/6] Rewrite auth-token-gen to be based on HMAC based tokens

2019-02-21 Thread Eric Thorpe
this log line is probably enough I think? Finally, the patch won't build under MSVC without the following change: +struct push_list push_list = {}; to +struct push_list push_list = {0}; auth_token.c and auth_token.h will need to be added to the VS solution as well however I'm happ

[Openvpn-devel] [Patch] Support client reason from auth plugin

2018-04-19 Thread Eric Thorpe
actor-extensions/tree/master/yubikey-u2f-pam-plugin Regards, Eric -- -- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com From 0970f16c27c2b90df04ad148bea84a9bfd3ad4a0 Mon Sep 17 00:00:00 2001 From: ethorpe Date: Wed, 18 Apr 2018 19:

Re: [Openvpn-devel] Viscosity patch to TAP driver

2018-04-12 Thread Eric Thorpe
Hi Gert, PR #47 has been submitted to tap-windows6 on github. Regards, Eric -- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com On 12/04/2018 6:26 PM, Gert Doering wrote: Hi Eric, On Thu, Mar 22, 2018 at 02:25:56PM +1100, Eric

Re: [Openvpn-devel] Summary of the community meeting (Wed, 21st Mar 2018)

2018-03-21 Thread Eric Thorpe
sed on its reported adapter speed, which is of course a problem if the VPN connection is capable of more than 100 Mbit. Please find a patch file of the changes attached. Regards, Eric -- Eric Thorpe SparkLabs Developer https://www.sparklabs.com https://twitter.com/sparklabs supp...@sparklabs.com

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-15 Thread Eric Thorpe
Hi, Patch below with the requested hunks removed. Signed-off by: Eric Thorpe diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in index 4bc89e7..7977cb8 100644 --- a/config-msvc-version.h.in +++ b/config-msvc-version.h.in @@ -1,8 +1,12 @@ #define PACKAGE_NAME "@PRODUCT

[Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-13 Thread Eric Thorpe
ntion to update the javascript generator. Signed-off by: Eric Thorpe --- diff --git a/config-msvc-version.h.in b/config-msvc-version.h.in index 4bc89e7..7977cb8 100644 --- a/config-msvc-version.h.in +++ b/config-msvc-version.h.in @@ -1,8 +1,12 @@ #define PACKAGE_NAME "@PRODUCT_NAME@