Hi,
See attached a very small patch (based on allmerged tree) to fix "sizeof".
Regards,
--
Emilien Mantel
Le 18/06/2010 02:01, Peter Stuge a écrit :
David Sommerseth wrote:
3) "sizeof(common_name)" is useless... Line 745: char
common_name[TLS_USERNAME_LEN];
t it's done in most of cases).
I suggest to call it "x509_primary_identifier", it's generic.
If you agree, I can prepare a patch soon based in allmerged tree.
Best regards,
--
Emilien Mantel
Le 17/06/2010 17:21, Alon Bar-Lev a écrit :
On Thu, Jun 17, 2010 at 5:51 PM, Emilien Mantel
wrote:
1) Done
2) Done
3) "sizeof(common_name)" is useless... Line 745: char
common_name[TLS_USERNAME_LEN]; we can use directly TLS_USERNAME_LEN.
Usually sizeof(XXX) should be
ommon_name" is very heavy :
emilienm@emilienm:~/dev/openvpn-testing$ grep -i common_name * | wc -l
165
Are you sure it's a good idea? If I do that, are you agree to rename it
"username"?
--
Emilien Mantel
Le 17/06/2010 15:57, Alon Bar-Lev a écrit :
Great.
Few more:
1. To upper:
cha
I added toupper() + #include in options.c
See attached.
--
Emilien Mantel
Le 17/06/2010 14:02, Alon Bar-Lev a écrit :
This is good idea.
In order to upper case toupper() should be used and not manual guessing.
+ else if (streq (p[0], "x509-username-field&quo
9-username-field", the default value is "CN".
Best regards
--
Emilien Mantel
diff --git a/options.c b/options.c
index 35f3f13..d2d04e2 100644
--- a/options.c
+++ b/options.c
@@ -533,6 +533,8 @@ static const char usage_message[] =
"--key file : Local private key in
