Re: [Openvpn-devel] [PATCH] Remove 1 second delay before running netsh

Hi! I've sent a new patch that uses management_sleep(0) instead. I've also added your explanation why management_sleep(0) is used. Regards, Domagoj On Mon, Dec 21, 2020 at 10:06:57AM +0200, Lev Stipakov wrote: > Hi, > > > Lev: do you have a particular opinion on this change? You do more > > t

[Openvpn-devel] [PATCH v2] Remove 1 second delay before running netsh

wait. Signed-off-by: Domagoj Pensa --- src/openvpn/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 400a50ca..0751ae46 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -5207,7 +5207,7 @@ netsh_command(const struct argv

Re: [Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

Hi! I've done some more investigation and I've found out that problem was introduced in commit: 09ae6280 tun.c: revise the IPv4 ifconfig flow on Windows in the following change: @@ -6420,10 +6419,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun struct

Re: [Openvpn-devel] [PATCH applied] Re: Fix too early argv freeing when registering DNS

> > Your patch has been applied to the master and release/2.5 branch. > > commit ab4688e3bd78d010ccc96adec66ab552bd009328 (master) > commit 2f2df474158b6c24325a47334fc8b5eb77a69b85 (release/2.5) > Author: Domagoj Pensa > Date: Tue Dec 15 18:16:00 2020 +0100 > > Fix too

[Openvpn-devel] [PATCH] Remove 1 second delay before running netsh

removed. Also, no delays are used in a similar code in interactive service and netsh command executions are guarded with a semaphore. Signed-off-by: Domagoj Pensa --- src/openvpn/tun.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 400a50ca..e9f1aadb

[Openvpn-devel] [PATCH] Fix too early argv freeing when registering DNS

: Domagoj Pensa --- src/openvpn/tun.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 400a50ca..2b227bb6 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -5235,7 +5235,6 @@ ipconfig_register_dns(const struct env_set *es

[Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

Wintun does not support DHCP. Running DHCP renew with Wintun adapter fails with a logged warning. Fixed so that DHCP renewing is called only for TAP-Windows6 adapters. --- src/openvpn/tun.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

Re: [Openvpn-devel] [PATCH applied] Re: Skip DNS address validation

On Fri, Mar 13, 2020 at 08:17:15PM +0100, Gert Doering wrote: > Your patch has been applied to the master branch. > > Sorry for the delay, it's been a very busy month. > No problem at all. Thank you for applying patch! :) Regards, Domagoj ___ Openvp

Re: [Openvpn-devel] [PATCH 1/2] Skip DNS address validation

Hi! My I ask if there is anything else I can (or should) do regarding this patch? Perhaps send patch again with revised/updated description as suggested by Simon? Thank you! Regards, Domagoj ___ Openvpn-devel mailing list Openvpn-devel@lists.source

Re: [Openvpn-devel] [PATCH 1/2] Skip DNS address validation

Hi! On Thu, Feb 06, 2020 at 09:58:37AM +, Simon Rozman wrote: > Hi, > > My thoughts exactly: as Lev pointed out: > https://github.com/rozmansi/openvpn/commit/6b746cb0bf72a75e9963cc1a037c18cfb > 856702a > > Acked-by: Simon Rozman > > Domagoj, if it's not too much for you, maybe document the

Re: [Openvpn-devel] Fwd: [PATCH 2/2] Fix linking issues on MinGW

Hi, On Wed, Feb 05, 2020 at 10:28:38AM -0500, Selva Nair wrote: > Are you building without optimization? Please try using the latest > openvpn-build (or just add -O2 to complier options). Yes, that was it! When Lev said that he doesn't have problems with build, I've noticed that he is using scr

Re: [Openvpn-devel] [PATCH 2/2] Fix linking issues on MinGW

Hi! On Wed, Feb 05, 2020 at 02:05:11PM +0100, Gert Doering wrote: > Hi, > > On Wed, Feb 05, 2020 at 01:46:15PM +0100, Domagoj Pensa wrote: > > MinGW linking fails for several files due to a missing "static" > > declaration in functions tuntap_is_wintun() and tuntap

Re: [Openvpn-devel] [PATCH 2/2] Fix linking issues on MinGW

Hi! On Wed, Feb 05, 2020 at 02:05:11PM +0100, Gert Doering wrote: > Hi, > > On Wed, Feb 05, 2020 at 01:46:15PM +0100, Domagoj Pensa wrote: > > MinGW linking fails for several files due to a missing "static" > > declaration in functions tuntap_is_wintun() and tuntap

[Openvpn-devel] [PATCH 2/2] Fix linking issues on MinGW

MinGW linking fails for several files due to a missing "static" declaration in functions tuntap_is_wintun() and tuntap_ring_empty(). Signed-off-by: Domagoj Pensa --- src/openvpn/tun.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/tun.h b/src/ope

[Openvpn-devel] [PATCH 1/2] Skip DNS address validation

When adding IPv4 DNS servers without interactive service use "validate=no", on Windows 7 and higher, to skip time consuming automatic address validation, that is on by default. Fix uses adapted code from commit 786e06a Signed-off-by: Domagoj Pensa --- src/openvpn/tun.c | 9 +++

[Openvpn-devel] [PATCH 0/2] Couple of fixes

rom openvpn-build repository. It is also worth noting that similar function tuntap_defined() with same signature (static inline bool) already exists in the same header file, so this change should be safe. Domagoj Pensa (2): Skip DNS address validation Fix linking issues on MinGW src/open