[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-05-22 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active ..

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-22 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) Change subject: dco_linux: avoid bogus text when netlink message is not parsed

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Arne Schwabe
Totally fair that you don't want to apply a patch that you don't understand. I on the other hand do not see why you're unable to reproduce. The scenario is not at all complicated: - Two vpn servers; - first vpn server pushes a default gateway; - second vpn server pushes its external IP as net_ga

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-22 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email to look at the new patch set (#2). The following approvals got outdated a

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email to review the following change. Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Walter Doekes via Openvpn-devel
> The thing is that I do not really understand your scenario and how it > exactly breaks for you to the extend that I cannot reproduce the issue. I thought I explained things sufficiently in: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31502.html Apparently not. Please le

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-22 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email ) Change subject: mbedtls: Allow TLS 1.3 if available .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-22 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Arne Schwabe
Am 22.05.2025 um 09:09 schrieb Walter Doekes: Dear mailing list and Arne, I saw in the IRC meeting notes that 2.7 is about to be branched. I don't mean to push, but I personally think this bug is important enough to get looked at and fixed, preferably before 2.7.0 is made. Is this new patch

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Walter Doekes via Openvpn-devel
Dear mailing list and Arne, I saw in the IRC meeting notes that 2.7 is about to be branched. I don't mean to push, but I personally think this bug is important enough to get looked at and fixed, preferably before 2.7.0 is made. Is this new patch good enough? Should I put it in Gerrit? Are there