[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update May 2025

2025-05-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1001?usp=email to review the following change. Change subject: GHA: Dependency and Actions update May 2025 ...

[Openvpn-devel] [M] Change in openvpn[master]: CMake: Reorganize header and symbol tests

2025-05-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/924?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: CMake: Reorganize header and symbol tests .

Re: [Openvpn-devel] [PATCH ovpn-net-next v2] ovpn: ensure sk is still valid during cleanup

2025-05-09 Thread Antonio Quartulli
On 06/05/2025 00:55, Antonio Quartulli wrote: Signed-off-by: Antonio Quartulli Merged to main, commit id 476148af4e28 So far we didn't spot any regression, so we'll move on with this fix for the time being as we know it is preventing the crash for good. We can improve it later if we feel

[Openvpn-devel] [PATCH applied] Re: CMake: Sync list of compiler flags with configure.ac

2025-05-09 Thread Gert Doering
Build-system only change. Description makes sense, the actual change looks reasonable, and BB says "it builds something successfully". The (void) chance is obviously correct. Your patch has been applied to the master branch. commit 0f1c26771cccb8ff26215d50fa94c290f82f331d Author: Frank Lichtenh

[Openvpn-devel] [PATCH applied] Re: CMake: Reorganize header and symbol tests

2025-05-09 Thread Gert Doering
Build system changes only, no code changes. BB and Arne agree that this is fine :-) (there are some build fails, but those look like unrelated network hickups in the middle of a t_client run). Grouping the tests sounds like a good speedup on platforms that do not have something, like ... Your p

[Openvpn-devel] [M] Change in openvpn[master]: CMake: Reorganize header and symbol tests

2025-05-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/924?usp=email ) Change subject: CMake: Reorganize header and symbol tests .. CMake: Reorganize header and symbol tests When we check for the header and th

[Openvpn-devel] [S] Change in openvpn[master]: CMake: Sync list of compiler flags with configure.ac

2025-05-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/923?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: CMake: Sync list of compiler flags with configure.a

[Openvpn-devel] [S] Change in openvpn[master]: CMake: Sync list of compiler flags with configure.ac

2025-05-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/923?usp=email ) Change subject: CMake: Sync list of compiler flags with configure.ac .. CMake: Sync list of compiler flags with configure.ac Also fix one

[Openvpn-devel] [PATCH v2] CMake: Sync list of compiler flags with configure.ac

2025-05-09 Thread Gert Doering
From: Frank Lichtenheld Also fix one issue reported by the build. Change-Id: I28af9eac2e9fb615903a82c8f4087602b72c134d Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerri

[Openvpn-devel] [S] Change in openvpn[master]: CMake: Sync list of compiler flags with configure.ac

2025-05-09 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/923?usp=email ) Change subject: CMake: Sync list of compiler flags with configure.ac ..