[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-04-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email ) Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake .. Fix mbed TLS key exporter functionality in 3.6.x and cmake C

[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-04-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Fix mbed TLS key exporter functionality in 3.6.x an

[Openvpn-devel] [PATCH applied] Re: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-04-25 Thread Gert Doering
This is basically a cmake build system fix (no code changes) together with code safeguards that we do not end up in a SIGSEGV because parts of the code assume "key exporter present" and the actual calls are not there... haven't tested this myself, but the buildbots have (and the macOS buildbot un

[Openvpn-devel] [PATCH v3] Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-04-25 Thread Gert Doering
From: Arne Schwabe Cmake did not check for the mbedtls_ssl_set_export_keys_cb symbol when generating an mbed TLS configuration. This causes no actual working key exporter to be in the binary. Also add an explicit #error to catch this situation during compilation. Change-Id: If38e80e268dc0ee7e57

[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-04-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email ) Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake ...

[Openvpn-devel] [M] Change in openvpn[master]: Make dh none behaviour default if not specified and add dh auto

2025-04-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/945?usp=email ) Change subject: Make dh none behaviour default if not specified and add dh auto ..