[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: ssl_openssl.c: Prevent potential double-free .

[Openvpn-devel] [PATCH applied] Re: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread Gert Doering
Not tested, as the offending code flow is quite obvious "in hindsight", and making the pointer NULL after free() is a sufficient safeguard against double free(). A slightly more readable construction could have used to different "info" variables for the two different scopes, each with its own indi

[Openvpn-devel] [PATCH v4] ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread Gert Doering
From: Lev Stipakov Fixes a potential double-free issue in tls_ctx_load_cert_uri() by explicitly nullifying the pointer immediately after calling OSSL_STORE_INFO_free(info). This ensures that subsequent cleanup won't attempt to free the same pointer again. GitHub: #726 Change-Id: I4507be07cd5

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free .. P

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#4). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#3). Change subject: ssl_openssl.c: Prevent

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to review the following change. Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .