cron2 has uploaded a new patch set (#4) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/855?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Improve error reporting from AF_UNIX tun/tap support
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/855?usp=email )
Change subject: Improve error reporting from AF_UNIX tun/tap support
..
Improve error reporting from AF_UNIX tun/tap support
When having a
Significant improvement, this :-)
Old code, when executing a nonexistant binary:
2025-02-01 19:33:56 Child process PID 7167 for afunix dead? Return code: 32512
2025-02-01 19:33:56 write to TUN/TAP : No error: 0 (fd=-1,code=0)
New code:
2025-02-01 19:35:06 Protocol options: protocol-flags tls-ek
From: Arne Schwabe
When having a non-existent lwipovpn binary or similar problems, the
error reporting would often only report read error that were harder to
identify the real problem. Add the openvpn_waitpid_check method
that checks for error conditions and reports a better message in cases
of
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/855?usp=email )
Change subject: Improve error reporting from AF_UNIX tun/tap support
..
From: Lev Stipakov
This doesn't matter for Linux and FreeBSD but matters
for dco-win, where iroute subnet is mapped to a peer
context, which means that peer has to be created before
iroute is added.
Change-Id: I1cac0f036504c87205a3c97589a94a662cf79b99
Signed-off-by: Lev Stipakov
Acked-by: Gert
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/856?usp=email )
Change subject: multi.c: add iroutes after dco peer is added
Hi,
On Sat, Feb 01, 2025 at 02:24:37PM +0800, Qingfang Deng wrote:
> #endif
> +if (sock->bind_local && sock->info.lsa->bind_local) {
> +localaddr = sock->info.lsa->bind_local->ai_addr;
> +}
> +
This is still not correct style - the opening "{" needs to go on its own
line. Also s
