Hi,
On Mon, Jan 27, 2025 at 03:50:14PM -0800, Shubham Mittal via Openvpn-devel
wrote:
> +export LD_LIBRARY_PATH="${AWS_LC_INSTALL_FOLDER}/lib"
This does not sound like a good way to get reliable operation - much
better is to use -Wl,-rpath at compile time.
gert
--
"If was one thing all peo
Attention is currently required from: cron2, flichtenheld, plaisthos.
mattock has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null
..
Pat
Attention is currently required from: flichtenheld, plaisthos.
kallisti5 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )
Change subject: Haiku: change del to delete in route command. del is
undocumented
Attention is currently required from: flichtenheld, plaisthos.
kallisti5 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/689?usp=email )
Change subject: Haiku: Fix short interface path length
..
Pat
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
to review the following change.
Change subject: Haiku: change del to delete in route command. de
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/689?usp=email
to review the following change.
Change subject: Haiku: Fix short interface path length
.
URL: https://github.com/OpenVPN/openvpn/pull/673
Acked-by: Arne Schwabe
Signed-off-by: Shubham Mittal
---
.github/workflows/build.yaml | 61
1 file changed, 61 insertions(+)
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 90d52
Additional context from PR on Github about changes in ssl_openssl.c around line
1900:
This change addresses a subtle behavioral difference between AWS-LC and OpenSSL
regarding object ownership semantics in SSL_CTX_set_client_CA_list(ctx->ctx,
cert_names).
OpenSSL Behavior:
Stores a reference to
Attention is currently required from: flichtenheld, ordex, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email
to look at the new patch set (#9).
Change subject: dco_linux: extend netlink err
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
.
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has removed a vote from this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
...
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
Change subject: Add unit tests for atoi parsing options helper
..
Patch Set 1:
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed
..
Print warnings/errors when numerical parameters cannot
cron2 has uploaded a new patch set (#9) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Print warnings/errors when numerical parameters cannot be
Stared long and hard at the "trivial" changes in v3..v7, and the result
now looks good and improves our reporting of config file errors, without
bloating all the option-by-option parsing. Passes my client/server tests,
which excercise a bit of the config parser (though only half of it, maybe).
Un
Attention is currently required from: flichtenheld, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Revi
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email
to look at the new patch set (#8).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Change subject: Print warnings/errors when nu
From: Arne Schwabe
Change-Id: Ieee368e325d7f9c367fd91fee0fd3e281ee0855d
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/87
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/877?usp=email
to review the following change.
Change subject: Fix doxygen warnings in crypto_epoch.h
.
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/848?usp=email
to look at the new patch set (#4).
Change subject: Doxygen: Fix missing parameter warnings
...
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
Change subject: Add unit tests for atoi parsing options helper
..
Patch
From: Arne Schwabe
Using the atoi method is a best effort method that parses as much of the
input string as possible as integer and ignores the rest or return 0
if the string cannot be parsed. This is lead to unexpected results.
Change the behaviour by printing a warning in these cases instead.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed
..
Patch Set 7: -Code-Review
--
To view, v
From: Antonio Quartulli
A netlink error may contain more specific attributes: i.e.
missing attributes or missing neted objects.
Parse and print this information too.
Note that we are re-defining some enum entries that exist
in netlink.h starting with linux-6.1.
Since we do support distros not s
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
Attention is currently required from: cron2, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+2 by
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email
to review the following change.
Change subject: Add unit tests for atoi parsing options helper
...
JFTR, v2 in gerrit is "the same as v1, just rebased", so taking what is
already on the list here.
And indeed, in the only call chain to this, we have
string_mod_remap_name(up->username);
.. so this should better be non-NULL :-) (ASSERT(str) in string_mod()).
Your patch has been applied to
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/871?usp=email )
Change subject: Remove comparing username to NULL in tls_lock_username
..
Remove comparing username to NULL in tls_lock_username
tls_lock_
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/871?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Remove comparing username to NULL in tls_lock_usern
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed
Attention is currently required from: flichtenheld, ordex.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email
to look at the new patch set (#8).
Change subject: dco_linux: extend netlink error cb with extra i
Attention is currently required from: flichtenheld, ordex.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email
to look at the new patch set (#7).
Change subject: dco_linux: extend netlink error cb with extra i
Attention is currently required from: flichtenheld, ordex.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email
to look at the new patch set (#6).
Change subject: dco_linux: extend netlink error cb with extra i
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/872?usp=email
to look at the new patch set (#5).
Change subject: Implement override-username
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/871?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
Attention is currently required from: plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email
to look at the new patch set (#6).
Change subject: Print warnings/errors when numerical parameters cannot be par
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed
Attention is currently required from: plaisthos, stipa.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/814?usp=email
to look at the new patch set (#11).
The change is no longer submittable: checks~ChecksSubmitRule is un
Attention is currently required from: flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/853?usp=email )
Change subject: Apply text-removal.sh script to Windows codebase
..
Attention is currently required from: flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/854?usp=email )
Change subject: Post tchar.h removal cleanup
..
Patch Set 2: Code
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/851?usp=email )
Change subject: openvpnserv: Fix some inconsistent usages of TEXT()
..
openvpnserv: Fix some inconsistent usages of TEXT()
In general you
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/851?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: openvpnserv: Fix some inconsistent usages of TEXT()
...
I have looked a bit at the patch and it seems reasonable. Lev has looked
harder and understands Windows, so that ACK is what counts ;-) - also
we have a mingw buildbot now, confirming that this isn't breaking
windows builds.
Your patch has been applied to the master branch.
commit 02412106f4065
From: Frank Lichtenheld
In general you can't use multiple strings as argument
to TEXT() since it just adds a L in front of the argument.
So if you specifiy multiple arguments the later argument
strings do not get the L.
This does not seem to directly cause problems with our
ASCII strings, but ma
Attention is currently required from: flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/851?usp=email )
Change subject: openvpnserv: Fix some inconsistent usages of TEXT()
...
48 matches
Mail list logo
